[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] tap: vhost busy polling support
From: |
Jason Wang |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] tap: vhost busy polling support |
Date: |
Fri, 25 Mar 2016 15:46:16 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 03/25/2016 04:34 AM, Eric Blake wrote:
> On 03/20/2016 11:25 PM, Jason Wang wrote:
>> This patch add the capability of basic vhost net busy polling which is
>> supported by recent kernel. User could configure the maximum number of
>> us that could be spent on busy polling through a new property of tap
>> "vhost_poll_us".
>>
>> Signed-off-by: Jason Wang <address@hidden>
>> ---
>> +++ b/qapi-schema.json
>> @@ -2532,7 +2532,8 @@
>> '*vhostfd': 'str',
>> '*vhostfds': 'str',
>> '*vhostforce': 'bool',
>> - '*queues': 'uint32'} }
>> + '*queues': 'uint32',
>> + '*vhost_poll_us': 'uint32'} }
> Missing documentation.
Right.
>
> New interfaces should prefer '-' over '_'; but this is an existing
> interface where we already have 'vnet_hdr', so intra-command consistency
> makes your naming okay.
>
Will change to use '-'.
Thanks