[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 00/40] ivshmem: Fixes, cleanups, device model spl
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PULL 00/40] ivshmem: Fixes, cleanups, device model split |
Date: |
Mon, 28 Mar 2016 09:38:30 +0300 |
On Mon, Mar 28, 2016 at 09:02:38AM +0300, Marcel Apfelbaum wrote:
> On 03/21/2016 02:11 PM, Markus Armbruster wrote:
> >Peter Maydell <address@hidden> writes:
> >
> >[...]
> >>Also some new clang ubsan warnings on x86 Linux:
> >>GTESTER check-qtest-i386
> >>[deleted existing warnings about slirp code]
> >>/home/petmay01/linaro/qemu-for-merges/hw/pci/pci.c:166:23: runtime
> >>error: shift exponent -1 is negative
> >>/home/petmay01/linaro/qemu-for-merges/hw/pci/pci.c:171:24: runtime
> >>error: shift exponent -1 is negative
> >>/home/petmay01/linaro/qemu-for-merges/hw/pci/pci.c:172:24: runtime
> >>error: shift exponent -1 is negative
> >
> >Root cause tracked down with the appended patch. PCI maintainers, you
> >might want to steal it.
> >
>
> Had anyone handled this already?
>
> Thanks,
> Marcel
No - pls post this as a patch.
> >
> >diff --git a/hw/pci/pci.c b/hw/pci/pci.c
> >index e67664d..1937c42 100644
> >--- a/hw/pci/pci.c
> >+++ b/hw/pci/pci.c
> >@@ -163,11 +163,13 @@ int pci_bar(PCIDevice *d, int reg)
> >
> > static inline int pci_irq_state(PCIDevice *d, int irq_num)
> > {
> >+ assert(irq_num >= 0);
> > return (d->irq_state >> irq_num) & 0x1;
> > }
> >
> > static inline void pci_set_irq_state(PCIDevice *d, int irq_num, int level)
> > {
> >+ assert(irq_num >= 0);
> > d->irq_state &= ~(0x1 << irq_num);
> > d->irq_state |= level << irq_num;
> > }
> >
- [Qemu-devel] [PULL 21/40] ivshmem: Assert interrupts are set up once, (continued)
- [Qemu-devel] [PULL 21/40] ivshmem: Assert interrupts are set up once, Markus Armbruster, 2016/03/18
- [Qemu-devel] [PULL 40/40] contrib/ivshmem-server: Print "not for production" warning, Markus Armbruster, 2016/03/18
- [Qemu-devel] [PULL 34/40] qdev: New DEFINE_PROP_ON_OFF_AUTO, Markus Armbruster, 2016/03/18
- [Qemu-devel] [PULL 36/40] ivshmem: Split ivshmem-plain, ivshmem-doorbell off ivshmem, Markus Armbruster, 2016/03/18
- Re: [Qemu-devel] [PULL 00/40] ivshmem: Fixes, cleanups, device model split, Peter Maydell, 2016/03/21
- Re: [Qemu-devel] [PULL 00/40] ivshmem: Fixes, cleanups, device model split, Markus Armbruster, 2016/03/21