[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] virtio-blk: use aio handler for data plane
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] virtio-blk: use aio handler for data plane |
Date: |
Tue, 29 Mar 2016 16:05:46 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 29/03/2016 15:42, Michael S. Tsirkin wrote:
> + if (s->dataplane) {
> + /* Some guests kick before setting VIRTIO_CONFIG_S_DRIVER_OK so start
> + * dataplane here instead of waiting for .set_status().
> + */
> + if (!s->dataplane_started) {
> + virtio_blk_data_plane_start(s->dataplane);
> + }
> + return;
> + }
> +
> + virtio_blk_handle_vq(s, vq);
Another small comment, this can be written simply as
if (s->dataplane) {
virtio_blk_data_plane_start(s->dataplane);
} else {
virtio_blk_handle_vq(s, vq);
}
Paolo
Re: [Qemu-devel] [PATCH 0/2] dataplane: fix start/stop races, Michael S. Tsirkin, 2016/03/29
Re: [Qemu-devel] [PATCH 0/2] dataplane: fix start/stop races, Cornelia Huck, 2016/03/29
Re: [Qemu-devel] [PATCH 0/2] dataplane: fix start/stop races, Christian Borntraeger, 2016/03/29