qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] xilinx_zynq: merged support for ULPI PHY and UL


From: Alistair Francis
Subject: Re: [Qemu-devel] [PATCH] xilinx_zynq: merged support for ULPI PHY and ULPI viewport from xilinx/qemu
Date: Tue, 29 Mar 2016 13:23:15 -0700

On Tue, Mar 29, 2016 at 12:51 PM,  <address@hidden> wrote:
> Signed-off-by: Joscha Benz <address@hidden>

Hello Joscha ,

Thanks for the patch. In future can you please use git send-email to
send the patches instead of attaching the patch file. You can find
more information on doing this at:
http://wiki.qemu.org/Contribute/SubmitAPatch

What are you trying to do here? Why are you trying to apply the Xilinx
model of the device? This relies on the register API (which you have
included in your patch) which isn't in mainline QEMU yet, so that part
can't be accepted just yet. We are working at upstreaming that at the
moment though.

Thanks,

Alistair

> ---
>  hw/usb/hcd-ehci-sysbus.c | 175 ++++++++++++++++++++++++++++++---
>  hw/usb/hcd-ehci.c        |   1 +
>  hw/usb/hcd-ehci.h        |  31 ++++++
>  include/hw/register.h    | 245 
> +++++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 441 insertions(+), 11 deletions(-)
>  create mode 100644 include/hw/register.h
>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]