[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/3] doc: Propose Structured Read extension
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/3] doc: Propose Structured Read extension |
Date: |
Tue, 29 Mar 2016 17:29:48 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 |
On 03/29/2016 05:01 PM, Eric Blake wrote:
> The existing transmission phase protocol is difficult to sniff,
> because correct interpretation of the server stream requires
> context from the client stream (or risks false positives if
> data payloads happen to contain the protocol magic numbers). It
> also prohibits the ability to do efficient sparse reads, or to
> return a short read where an error is reported without also
> sending length bytes of (bogus) data.
>
> +* `NBD_CMD_READ`
> +
> + If `NBD_OPT_STRUCTURED_READ` was not negotiated, then a read
> + request MUST always be answered by a single non-structured
> + response, as documented above (using magic 0x67446698
> + `NBD_REPLY_MAGIC`, and containing length bytes of data according
> + to the client's request, although those bytes MAY be invalid if an
> + error is returned, and the connection MUST if an error occurs
MUST be closed
(I hate it when I send patches before 'git commit --amend' on the final
unsaved changes in my editor...)
> + after a header claiming no error).
> +
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [Nbd] [PATCH 3/1] doc: Propose Structured Replies extension, (continued)
- Re: [Qemu-devel] [Nbd] [PATCH 3/1] doc: Propose Structured Replies extension, Alex Bligh, 2016/03/29
- Re: [Qemu-devel] [Nbd] [PATCH 3/1] doc: Propose Structured Replies extension, Wouter Verhelst, 2016/03/29
- Re: [Qemu-devel] [Nbd] [PATCH 3/1] doc: Propose Structured Replies extension, Alex Bligh, 2016/03/29
- Re: [Qemu-devel] [Nbd] [PATCH 3/1] doc: Propose Structured Replies extension, Wouter Verhelst, 2016/03/29
- Re: [Qemu-devel] [Nbd] [PATCH 3/1] doc: Propose Structured Replies extension, Alex Bligh, 2016/03/29
Re: [Qemu-devel] [PATCH] doc: Mention proper use of handle, Wouter Verhelst, 2016/03/29
[Qemu-devel] [PATCH v2 0/3] NBD Structured Read, Eric Blake, 2016/03/29
- [Qemu-devel] [PATCH v2 2/3] doc: Mention proper use of handle, Eric Blake, 2016/03/29
- [Qemu-devel] [PATCH v2 3/3] doc: Propose Structured Read extension, Eric Blake, 2016/03/29
- Re: [Qemu-devel] [PATCH v2 3/3] doc: Propose Structured Read extension,
Eric Blake <=
- Re: [Qemu-devel] [PATCH v2 3/3] doc: Propose Structured Read extension, Alex Bligh, 2016/03/30
- Re: [Qemu-devel] [PATCH v2 3/3] doc: Propose Structured Read extension, Eric Blake, 2016/03/30
- Re: [Qemu-devel] [Nbd] [PATCH v2 3/3] doc: Propose Structured Read extension, Wouter Verhelst, 2016/03/30
- Re: [Qemu-devel] [Nbd] [PATCH v2 3/3] doc: Propose Structured Read extension, Eric Blake, 2016/03/30
- Re: [Qemu-devel] [Nbd] [PATCH v2 3/3] doc: Propose Structured Read extension, Wouter Verhelst, 2016/03/30
Re: [Qemu-devel] [PATCH v2 3/3] doc: Propose Structured Read extension, Alex Bligh, 2016/03/30
Re: [Qemu-devel] [Nbd] [PATCH v2 3/3] doc: Propose Structured Read extension, Wouter Verhelst, 2016/03/30
[Qemu-devel] [PATCH v2 1/3] NBD proto: add "Command flags" section, Eric Blake, 2016/03/29
Re: [Qemu-devel] [Nbd] [PATCH v2 0/3] NBD Structured Read, Wouter Verhelst, 2016/03/30