[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 2/3] block: add support for encryption secret
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v7 2/3] block: add support for encryption secrets in block I/O tests |
Date: |
Wed, 30 Mar 2016 17:51:16 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 |
On 30.03.2016 15:53, Daniel P. Berrange wrote:
> The LUKS block driver tests will require the ability to specify
> encryption secrets with block devices. This requires using the
> --object argument to qemu-img/qemu-io to create a 'secret'
> object.
>
> When the IMGKEYSECRET env variable is set, it provides the
> password to be associated with a secret called 'keysec0'
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> tests/qemu-iotests/common | 1 +
> tests/qemu-iotests/common.config | 6 ++++++
> tests/qemu-iotests/common.filter | 3 ++-
> tests/qemu-iotests/common.rc | 16 +++++++++++++---
> 4 files changed, 22 insertions(+), 4 deletions(-)
Is there a reason why you didn't implement the same logic in
_qemu_img_wrapper as in _qemu_io_wrapper?
This works, but it appears a bit overcomplicated to me.
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature