[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] net: fix OptsVisitor memory leak
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] net: fix OptsVisitor memory leak |
Date: |
Thu, 31 Mar 2016 10:22:37 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 |
On 03/31/2016 08:28 AM, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <address@hidden>
May want to add: regression introduced in commit 96a1616.
> ---
> net/net.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/net/net.c b/net/net.c
> index 594c3b8..3847a13 100644
> --- a/net/net.c
> +++ b/net/net.c
> @@ -1100,6 +1100,7 @@ int net_client_init(QemuOpts *opts, int is_netdev,
> Error **errp)
> }
>
> error_propagate(errp, err);
> + opts_visitor_cleanup(ov);
> return ret;
> }
>
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature