[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v3 06/19] tcg: comment on which functions have to
From: |
Sergey Fedorov |
Subject: |
Re: [Qemu-devel] [RFC v3 06/19] tcg: comment on which functions have to be called with tb_lock held |
Date: |
Fri, 24 Jun 2016 18:38:35 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 |
On 03/06/16 23:40, Alex Bennée wrote:
> diff --git a/translate-all.c b/translate-all.c
> index e3f44d9..8b162ff 100644
> --- a/translate-all.c
> +++ b/translate-all.c
(snip)
> @@ -347,8 +349,10 @@ bool cpu_restore_state(CPUState *cpu, uintptr_t retaddr)
> cpu_restore_state_from_tb(cpu, tb, retaddr);
> if (tb->cflags & CF_NOCACHE) {
> /* one-shot translation, invalidate it immediately */
> + tb_lock();
> tb_phys_invalidate(tb, -1);
> tb_free(tb);
> + tb_unlock();
Looks like this belongs to another patch ;-)
> }
> return true;
> }
>
Kind regards,
Sergey
- Re: [Qemu-devel] [RFC v3 01/19] cpus: make all_vcpus_paused() return bool, (continued)
- [Qemu-devel] [RFC v3 02/19] translate_all: DEBUG_FLUSH -> DEBUG_TB_FLUSH, Alex Bennée, 2016/06/03
- [Qemu-devel] [RFC v3 03/19] translate-all: add DEBUG_LOCKING asserts, Alex Bennée, 2016/06/03
- [Qemu-devel] [RFC v3 05/19] exec: add assert_debug_safe and notes on debug structures, Alex Bennée, 2016/06/03
- [Qemu-devel] [RFC v3 06/19] tcg: comment on which functions have to be called with tb_lock held, Alex Bennée, 2016/06/03
- Re: [Qemu-devel] [RFC v3 06/19] tcg: comment on which functions have to be called with tb_lock held,
Sergey Fedorov <=
- [Qemu-devel] [RFC v3 04/19] docs: new design document multi-thread-tcg.txt (DRAFTING), Alex Bennée, 2016/06/03
- [Qemu-devel] [RFC v3 07/19] translate-all: Add assert_memory_lock annotations, Alex Bennée, 2016/06/03
- [Qemu-devel] [RFC v3 12/19] tcg: add kick timer for single-threaded vCPU emulation, Alex Bennée, 2016/06/03
- [Qemu-devel] [RFC v3 08/19] tcg: protect TBContext with tb_lock., Alex Bennée, 2016/06/03
- [Qemu-devel] [RFC v3 11/19] tcg: add options for enabling MTTCG, Alex Bennée, 2016/06/03
- [Qemu-devel] [RFC v3 13/19] tcg: rename tcg_current_cpu to tcg_current_rr_cpu, Alex Bennée, 2016/06/03