|
| From: | Richard Henderson |
| Subject: | Re: [Qemu-devel] [PATCH v10 09/10] target-avr: updating translate.c to use instructions translation |
| Date: | Wed, 13 Jul 2016 00:21:50 -0700 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 07/12/2016 08:49 PM, Michael Rolnik wrote:
if I fold this patch into previous ones, they will become non buildable, because this patch assumes existance of functions from the preceding patch. Is this acceptable?
All patches need to be buildable, so that git bisect works.The previous patches are already (sort of) non-buildable, but you don't notice because you've not added translate-inst.o to obj-y until here. But there's certainly no reason to put code in translate.c in one patch, then move it to translate.h in another.
r~
| [Prev in Thread] | Current Thread | [Next in Thread] |