|
From: | John Snow |
Subject: | Re: [Qemu-devel] [PATCH] tests/hd-geo-test: Don't pass NULL to unlink() |
Date: | Tue, 6 Sep 2016 15:15:38 -0400 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
On 09/06/2016 03:07 PM, Peter Maydell wrote:
On 6 September 2016 at 20:06, John Snow <address@hidden> wrote:On 09/06/2016 08:47 AM, Peter Maydell wrote:Ping?Not sure who this belongs to; I can queue it up alongside some IDE and FDC stuff in the future if you like.I can apply it directly; I'd just like review :-)
lol! yes, of course you can...
thanks -- PMM
Well, I know some have religious arguments against making sanitizers happy, but that's not my religion.
If some systems appear to think that unlink must take a nonnull argument, I think that's a bug -- but making the sanitizer happy doesn't cost us much either IMO.
(And it's /just/ a test.) So, personally: Reviewed-by: John Snow <address@hidden>
[Prev in Thread] | Current Thread | [Next in Thread] |