Re: [Qemu-devel] [RFC PATCH 00/13] VT-d replay and misc cleanup

[Peter Xu]

On Sun, Dec 18, 2016 at 04:42:50PM +0800, Liu, Yi L wrote:
> On Tue, Dec 06, 2016 at 06:36:15PM +0800, Peter Xu wrote:
> > This RFC series is a continue work for Aviv B.D.'s vfio enablement
> > series with vt-d. Aviv has done a great job there, and what we still
> > lack there are mostly the following:
> > 
> > (1) VFIO got duplicated IOTLB notifications due to splitted VT-d IOMMU
> >     memory region.
> > 
> > (2) VT-d still haven't provide a correct replay() mechanism (e.g.,
> >     when IOMMU domain switches, things will broke).
> > 
> > Here I'm trying to solve the above two issues.
> > 
> > (1) is solved by patch 7, (2) is solved by patch 11-12.
> > 
> > Basically it contains the following:
> > 
> > patch 1:    picked up from Jason's vhost DMAR series, which is a bugfix
> > 
> > patch 2-6:  Cleanups/Enhancements for existing vt-d codes (please see
> >             specific commit message for details, there are patches
> >             that I thought may be suitable for 2.8 as well, but looks
> >             like it's too late)
> > 
> > patch 7:    Solve the issue that vfio is notified more than once for
> >             IOTLB notifications with Aviv's patches
> > 
> > patch 8-10: Some trivial memory APIs added for further patches, and
> >             add customize replay() support for MemoryRegion (I see
> >             Aviv's latest v7 contains similar replay, I can rebase
> >             onto that, merely the same thing)
> > 
> > patch 11:   Provide a valid vt-d replay() callback, using page walk
> > 
> Peter,
> Does your patch set based on Aviv's patch？ I found the page cannot be
> applied in my side.

Hi, Yi,

This series is based on Aviv's v6 series. If you wanna try it, you may
want to fetch the tree from:

 https://github.com/xzpeter/qemu/tree/vtd-vfio-enablement

So you won't need to bother on the applying.

> 
> BTW. it may be better if you can split the patches for mis cleanup
> and the patches for replay/"fix duplicate notify".

Yes. Here I just want to make sure things are stick together (e.g., to
test the replay, I will need to use the traces). And I feel it awkward
to maintain several series upstream while they interact with each
other. Sorry for the troublesome.

Thanks,

-- peterx