[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH v3 7/7] block/curl: code cleanup to
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH v3 7/7] block/curl: code cleanup to comply with coding style |
|
Date: |
Wed, 8 Nov 2017 16:04:21 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 08/11/2017 15:50, Darren Kenny wrote:
>> But, since checkpatch.pl doesn't flag it, and since it is easier to
>> remove the leading and trailing /* and */ to enable the debug #defines
>> (compared to editing every single line of the comment), I don't see a
>> problem with the style chosen here.
>
> If that is the purpose, maybe an #if 0 is more appropriate or #ifdef
> DEBUG, or similar.
>
> Isn't the purpose of styling to be consistent? As such should we not
> be trying to use the multi-line style set out at the top of the file?
Yes, and you're very welcome to submit a checkpatch.pl patch that warns
about that comment style without * at the beginning of each line.
On the other hand, style should not get in the way, and the version that
gets least in the way for debug #defines is //.
Paolo
[Qemu-devel] [PATCH v3 6/7] block/curl: fix minor memory leaks, Jeff Cody, 2017/11/07
[Qemu-devel] [PATCH v3 5/7] block/curl: check error return of curl_global_init(), Jeff Cody, 2017/11/07