[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 11/13] qapi2texi: De-duplicate code to add blank line
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL 11/13] qapi2texi: De-duplicate code to add blank line before symbol |
Date: |
Wed, 20 Dec 2017 19:59:22 +0100 |
Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
---
scripts/qapi2texi.py | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/scripts/qapi2texi.py b/scripts/qapi2texi.py
index 58add26c11..92e2af2cd6 100755
--- a/scripts/qapi2texi.py
+++ b/scripts/qapi2texi.py
@@ -206,8 +206,6 @@ class QAPISchemaGenDocVisitor(qapi.QAPISchemaVisitor):
def visit_enum_type(self, name, info, values, prefix):
doc = self.cur_doc
- if self.out:
- self.out += '\n'
self.out += TYPE_FMT(type='Enum',
name=doc.symbol,
body=texi_entity(doc, 'Values',
@@ -217,16 +215,12 @@ class QAPISchemaGenDocVisitor(qapi.QAPISchemaVisitor):
doc = self.cur_doc
if base and base.is_implicit():
base = None
- if self.out:
- self.out += '\n'
self.out += TYPE_FMT(type='Object',
name=doc.symbol,
body=texi_entity(doc, 'Members', base, variants))
def visit_alternate_type(self, name, info, variants):
doc = self.cur_doc
- if self.out:
- self.out += '\n'
self.out += TYPE_FMT(type='Alternate',
name=doc.symbol,
body=texi_entity(doc, 'Members'))
@@ -234,8 +228,6 @@ class QAPISchemaGenDocVisitor(qapi.QAPISchemaVisitor):
def visit_command(self, name, info, arg_type, ret_type,
gen, success_response, boxed):
doc = self.cur_doc
- if self.out:
- self.out += '\n'
if boxed:
body = texi_body(doc)
body += ('address@hidden:} the members of @code{%s}\n'
@@ -249,13 +241,13 @@ class QAPISchemaGenDocVisitor(qapi.QAPISchemaVisitor):
def visit_event(self, name, info, arg_type, boxed):
doc = self.cur_doc
- if self.out:
- self.out += '\n'
self.out += MSG_FMT(type='Event',
name=doc.symbol,
body=texi_entity(doc, 'Arguments'))
def symbol(self, doc, entity):
+ if self.out:
+ self.out += '\n'
self.cur_doc = doc
entity.visit(self)
self.cur_doc = None
--
2.13.6
- [Qemu-devel] [PULL 03/13] qapi: Eliminate QAPISchemaParser.__init__()'s local fname, (continued)
- [Qemu-devel] [PULL 03/13] qapi: Eliminate QAPISchemaParser.__init__()'s local fname, Markus Armbruster, 2017/12/20
- [Qemu-devel] [PULL 07/13] qapi: Unify representation of doc section without name, Markus Armbruster, 2017/12/20
- [Qemu-devel] [PULL 10/13] qapi: Rename QAPIDoc.parser, .section to ._parser, ._section, Markus Armbruster, 2017/12/20
- [Qemu-devel] [PULL 09/13] qapi2texi: Simplify representation of section text, Markus Armbruster, 2017/12/20
- [Qemu-devel] [PULL 06/13] qapi2texi: Clean up texi_sections(), Markus Armbruster, 2017/12/20
- [Qemu-devel] [PULL 04/13] qapi: Make cur_doc local to QAPISchemaParser.__init__(), Markus Armbruster, 2017/12/20
- [Qemu-devel] [PULL 12/13] qapi-docs: fix a comment typo, Markus Armbruster, 2017/12/20
- [Qemu-devel] [PULL 08/13] qapi: Simplify representation of QAPIDoc section text, Markus Armbruster, 2017/12/20
- [Qemu-devel] [PULL 02/13] qapi: Stop rejecting #optional, Markus Armbruster, 2017/12/20
- [Qemu-devel] [PULL 01/13] qapi-schema: Fix query-vm-generation-id's doc comment markup, Markus Armbruster, 2017/12/20
- [Qemu-devel] [PULL 11/13] qapi2texi: De-duplicate code to add blank line before symbol,
Markus Armbruster <=
- [Qemu-devel] [PULL 05/13] tests/qapi-schema/doc-bad-section: New, factored out of doc-good, Markus Armbruster, 2017/12/20
- [Qemu-devel] [PULL 13/13] qmp: remove qmp_cpu, Markus Armbruster, 2017/12/20
- Re: [Qemu-devel] [PULL 00/13] QAPI patches for 2017-12-20, Peter Maydell, 2017/12/20