Re: [Qemu-devel] [PATCH v3 27/39] qcow2: Update qcow2_update_snapshot_refcount() to support L2 slices

[Alberto Garcia]

On Thu 01 Feb 2018 08:26:26 PM CET, Max Reitz <address@hidden> wrote:
>> @@ -1273,12 +1276,13 @@ int qcow2_update_snapshot_refcount(BlockDriverState 
>> *bs,
>>                      case QCOW2_CLUSTER_NORMAL:
>>                      case QCOW2_CLUSTER_ZERO_ALLOC:
>>                          if (offset_into_cluster(s, offset)) {
>> +                            int l2_index = slice * s->l2_slice_size + j;
>>                              qcow2_signal_corruption(
>>                                  bs, true, -1, -1, "Cluster "
>>                                  "allocation offset %#" PRIx64
>>                                  " unaligned (L2 offset: %#"
>>                                  PRIx64 ", L2 index: %#x)",
>> -                                offset, l2_offset, j);
>> +                                offset, l2_offset, l2_index);
>
> This makes it a bit weird that in other patches l2_index is now
> generally the L2 slice index...

You're right, I can call it l2_table_index, I think this is the only
case where it does not refer to the slice index.

Berto