Re: [Qemu-devel] [PATCH v2] s390: avoid potential null dereference ins390_pcihost_unplug()

[李强]

At 2019-01-08 00:10:29, "Cornelia Huck" <address@hidden> wrote:
>On Mon, 7 Jan 2019 16:04:35 +0000
>Peter Maydell <address@hidden> wrote:
>
>> On Mon, 7 Jan 2019 at 15:57, Cornelia Huck <address@hidden> wrote:
>> > On Mon, 7 Jan 2019 15:54:21 +0000
>> > Peter Maydell <address@hidden> wrote:  
>> > > On Mon, 7 Jan 2019 at 15:48, Cornelia Huck <address@hidden> wrote:  
>> > > > Sounds good. But please return anyway in the unplug case, so that the
>> > > > code is fine if asserts have been configured out.  
>> > >
>> > > Hopefully that won't cause the compiler to complain about
>> > > unreachable code :-)  
>> >
>> > BTW: Is there a common configuration where asserts are configured out?
>> > Not that this is an accident waiting to happen...  
>> 
>> No -- we insist they are always enabled, and osdep.h will #error
>> out if either NDEBUG or G_DISABLE_ASSERT are set.
>
>Ah, now I remember (I thought we still had that problem.)
>

>In that case, no return is needed.


Ok, later I will send out a revised patch.


Thanks,
Li Qiang