[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/2] Revert "globals: Allow global properties
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 2/2] Revert "globals: Allow global properties to be optional" |
|
Date: |
Mon, 20 May 2019 18:00:40 -0300 |
|
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Fri, Feb 15, 2019 at 10:32:39AM +0000, Daniel P. Berrangé wrote:
> This reverts commit d7741743f4f3d2683d1bb6938f88dc0167c21afa.
>
> Relying on setting properties on parents types which may not
> be relevant to certain sub-classes had unexpected side-effects
> causing bugs in device config defaults. It is preferrable to
> be explicit about which devices get which properties, even if
> this needs repetition.
>
> Signed-off-by: Daniel P. Berrangé <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
--
Eduardo
[Qemu-devel] [PULL 02/37] Revert "globals: Allow global properties to be optional", Michael S. Tsirkin, 2019/05/16
- Re: [Qemu-devel] [PATCH v2 2/2] Revert "globals: Allow global properties to be optional",
Eduardo Habkost <=
[Qemu-devel] [PULL 03/37] docs: reST-ify vhost-user documentation, Michael S. Tsirkin, 2019/05/16
[Qemu-devel] [PULL 04/37] virtio: Introduce started flag to VirtioDevice, Michael S. Tsirkin, 2019/05/16