[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 02/11] memory: Remove memory_region_get_dirty()
From: |
Peter Xu |
Subject: |
[Qemu-devel] [PATCH v4 02/11] memory: Remove memory_region_get_dirty() |
Date: |
Mon, 3 Jun 2019 14:50:47 +0800 |
It's never used anywhere.
Reviewed-by: Paolo Bonzini <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Peter Xu <address@hidden>
---
include/exec/memory.h | 17 -----------------
memory.c | 8 --------
2 files changed, 25 deletions(-)
diff --git a/include/exec/memory.h b/include/exec/memory.h
index 9144a47f57..e6140e8a04 100644
--- a/include/exec/memory.h
+++ b/include/exec/memory.h
@@ -1254,23 +1254,6 @@ void memory_region_ram_resize(MemoryRegion *mr,
ram_addr_t newsize,
*/
void memory_region_set_log(MemoryRegion *mr, bool log, unsigned client);
-/**
- * memory_region_get_dirty: Check whether a range of bytes is dirty
- * for a specified client.
- *
- * Checks whether a range of bytes has been written to since the last
- * call to memory_region_reset_dirty() with the same @client. Dirty logging
- * must be enabled.
- *
- * @mr: the memory region being queried.
- * @addr: the address (relative to the start of the region) being queried.
- * @size: the size of the range being queried.
- * @client: the user of the logging information; %DIRTY_MEMORY_MIGRATION or
- * %DIRTY_MEMORY_VGA.
- */
-bool memory_region_get_dirty(MemoryRegion *mr, hwaddr addr,
- hwaddr size, unsigned client);
-
/**
* memory_region_set_dirty: Mark a range of bytes as dirty in a memory region.
*
diff --git a/memory.c b/memory.c
index 3071c4bdad..0920c105aa 100644
--- a/memory.c
+++ b/memory.c
@@ -2027,14 +2027,6 @@ void memory_region_set_log(MemoryRegion *mr, bool log,
unsigned client)
memory_region_transaction_commit();
}
-bool memory_region_get_dirty(MemoryRegion *mr, hwaddr addr,
- hwaddr size, unsigned client)
-{
- assert(mr->ram_block);
- return cpu_physical_memory_get_dirty(memory_region_get_ram_addr(mr) + addr,
- size, client);
-}
-
void memory_region_set_dirty(MemoryRegion *mr, hwaddr addr,
hwaddr size)
{
--
2.17.1
- [Qemu-devel] [PATCH v4 00/11] kvm/migration: support KVM_CLEAR_DIRTY_LOG, Peter Xu, 2019/06/03
- [Qemu-devel] [PATCH v4 01/11] migration: No need to take rcu during sync_dirty_bitmap, Peter Xu, 2019/06/03
- [Qemu-devel] [PATCH v4 02/11] memory: Remove memory_region_get_dirty(),
Peter Xu <=
- [Qemu-devel] [PATCH v4 03/11] memory: Don't set migration bitmap when without migration, Peter Xu, 2019/06/03
- [Qemu-devel] [PATCH v4 04/11] bitmap: Add bitmap_copy_with_{src|dst}_offset(), Peter Xu, 2019/06/03
- [Qemu-devel] [PATCH v4 05/11] memory: Pass mr into snapshot_and_clear_dirty, Peter Xu, 2019/06/03
- [Qemu-devel] [PATCH v4 06/11] memory: Introduce memory listener hook log_clear(), Peter Xu, 2019/06/03
- [Qemu-devel] [PATCH v4 07/11] kvm: Update comments for sync_dirty_bitmap, Peter Xu, 2019/06/03
- [Qemu-devel] [PATCH v4 08/11] kvm: Persistent per kvmslot dirty bitmap, Peter Xu, 2019/06/03
- [Qemu-devel] [PATCH v4 09/11] kvm: Introduce slots lock for memory listener, Peter Xu, 2019/06/03