Re: [Qemu-devel] [PATCH v3 4/4] egl-helpers: add modifier support to egl_dmabuf_import_texture()

[Gerd Hoffmann]

  Hi,

> > +#ifdef EGL_DMA_BUF_PLANE0_MODIFIER_LO_EXT
> > +    if (dmabuf->modifier) {
> > +        attrs[i++] = EGL_DMA_BUF_PLANE0_MODIFIER_LO_EXT;
> > +        attrs[i++] = (dmabuf->modifier >>  0) & 0xffffffff;
> > +        attrs[i++] = EGL_DMA_BUF_PLANE0_MODIFIER_HI_EXT;
> > +        attrs[i++] = (dmabuf->modifier >> 32) & 0xffffffff;
> > +    }
> > +#endif
> 
> Shouldn't there be at least a warning for #else?

I don't think so.  In most cases (single gpu device in the host) things
will work fine even without specifying the modifier.

cheers,
  Gerd