[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 00/22] s390x/tcg: Vector Instruction Support
From: |
David Hildenbrand |
Subject: |
Re: [Qemu-devel] [PATCH v2 00/22] s390x/tcg: Vector Instruction Support Part 4 |
Date: |
Mon, 3 Jun 2019 11:09:03 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 03.06.19 11:06, David Hildenbrand wrote:
> This is the final part of vector instruction support for s390x.
>
> Part 1: Vector Support Instructions
> Part 2: Vector Integer Instructions
> Part 3: Vector String Instructions
> Part 4: Vector Floating-Point Instructions
>
> The current state can be found at (kept updated):
> https://github.com/davidhildenbrand/qemu/tree/vx
>
> It is based on:
> - [PATCH v2 0/5] s390x/tcg: Vector Instruction Support Part 3
> - [PATCH v1 0/2] s390x: Fix vector register alignment
>
> With the current state I can boot Linux kernel + user space compiled with
> SIMD support. This allows to boot distributions compiled exclusively for
> z13, requiring SIMD support. Also, it is now possible to build a complete
> kernel using rpmbuild as quite some issues have been sorted out.
>
> While the current state works fine for me with RHEL 8, I am experiencing
> some issues with newer userspace versions. I already found and fixed
> some stack overflow protection issues (stfle instruction). I still see
> random rpm database corruptions and rpmbuild doesn't work correctly
> (looks like another stack protection issue).
>
> In this part, all Vector Floating-Point Instructions introduced with the
> "Vector Facility" are added. Also, the "qemu" model is changed to a
> z13 machine.
>
> v1 -> v2:
> - get rid of make_float64() and float64_val().
> - fixed two cc calculation issues (thanks Richard)
> - Rework "VECTOR FP COMPARE (EQUAL|HIGH|HIGH OR EQUAL)"
> - Rework "VECTOR FP MULTIPLY AND (ADD|SUBTRACT)"
> - Use gvec expansion in "s390x/tcg: Implement VECTOR FP PERFORM SIGN
> OPERATION"
>
> Cc: Denys Vlasenko <address@hidden>
> Cc: Christian Borntraeger <address@hidden>
> Cc: Pino Toscano <address@hidden>
>
> David Hildenbrand (22):
> s390x/tcg: Store only the necessary amount of doublewords for STFLE
> s390x/tcg: Introduce tcg_s390_vector_exception()
> s390x/tcg: Export float_comp_to_cc() and float(32|64|128)_dcmask()
> s390x/tcg: Implement VECTOR FP ADD
> s390x/tcg: Implement VECTOR FP COMPARE (AND SIGNAL) SCALAR
> s390x/tcg: Implement VECTOR FP COMPARE (EQUAL|HIGH|HIGH OR EQUAL)
> s390x/tcg: Implement VECTOR FP CONVERT FROM FIXED 64-BIT
> s390x/tcg: Implement VECTOR FP CONVERT FROM LOGICAL 64-BIT
> s390x/tcg: Implement VECTOR FP CONVERT TO FIXED 64-BIT
> s390x/tcg: Implement VECTOR FP CONVERT TO LOGICAL 64-BIT
> s390x/tcg: Implement VECTOR FP DIVIDE
> s390x/tcg: Implement VECTOR LOAD FP INTEGER
> s390x/tcg: Implement VECTOR LOAD LENGTHENED
> s390x/tcg: Implement VECTOR LOAD ROUNDED
> s390x/tcg: Implement VECTOR FP MULTIPLY
> s390x/tcg: Implement VECTOR FP MULTIPLY AND (ADD|SUBTRACT)
> s390x/tcg: Implement VECTOR FP PERFORM SIGN OPERATION
> s390x/tcg: Implement VECTOR FP SQUARE ROOT
> s390x/tcg: Implement VECTOR FP SUBTRACT
> s390x/tcg: Implement VECTOR FP TEST DATA CLASS IMMEDIATE
> s390x/tcg: Allow linux-user to use vector instructions
> s390x/tcg: We support the Vector Facility
>
> target/s390x/Makefile.objs | 1 +
> target/s390x/cpu.c | 3 +
> target/s390x/cpu.h | 1 +
> target/s390x/excp_helper.c | 15 +
> target/s390x/fpu_helper.c | 4 +-
> target/s390x/gen-features.c | 1 +
> target/s390x/helper.h | 46 +++
> target/s390x/insn-data.def | 45 +++
> target/s390x/internal.h | 4 +
> target/s390x/misc_helper.c | 8 +-
> target/s390x/tcg_s390x.h | 2 +
> target/s390x/translate_vx.inc.c | 284 +++++++++++++++
> target/s390x/vec_fpu_helper.c | 625 ++++++++++++++++++++++++++++++++
> 13 files changed, 1036 insertions(+), 3 deletions(-)
> create mode 100644 target/s390x/vec_fpu_helper.c
>
Still tired, the unchanged patch
"[PATCH v1 23/23] s390x: Bump the "qemu" CPU model up to a stripped-down
z13"
is missing from this series (already reviewed by Richard)
--
Thanks,
David / dhildenb
- [Qemu-devel] [PATCH v2 17/22] s390x/tcg: Implement VECTOR FP PERFORM SIGN OPERATION, (continued)
- [Qemu-devel] [PATCH v2 17/22] s390x/tcg: Implement VECTOR FP PERFORM SIGN OPERATION, David Hildenbrand, 2019/06/03
- [Qemu-devel] [PATCH v2 18/22] s390x/tcg: Implement VECTOR FP SQUARE ROOT, David Hildenbrand, 2019/06/03
- [Qemu-devel] [PATCH v2 19/22] s390x/tcg: Implement VECTOR FP SUBTRACT, David Hildenbrand, 2019/06/03
- [Qemu-devel] [PATCH v2 21/22] s390x/tcg: Allow linux-user to use vector instructions, David Hildenbrand, 2019/06/03
- [Qemu-devel] [PATCH v2 20/22] s390x/tcg: Implement VECTOR FP TEST DATA CLASS IMMEDIATE, David Hildenbrand, 2019/06/03
- [Qemu-devel] [PATCH v2 22/22] s390x/tcg: We support the Vector Facility, David Hildenbrand, 2019/06/03
- Re: [Qemu-devel] [PATCH v2 00/22] s390x/tcg: Vector Instruction Support Part 4,
David Hildenbrand <=
- [Qemu-devel] [PATCH v2 23/22] s390x: Bump the "qemu" CPU model up to a stripped-down z13, David Hildenbrand, 2019/06/03