qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] iotests: Fix duplicated diff output on failure


From: Alex Bennée
Subject: Re: [Qemu-devel] [PATCH] iotests: Fix duplicated diff output on failure
Date: Mon, 03 Jun 2019 15:24:55 +0100
User-agent: mu4e 1.3.2; emacs 26.1

Kevin Wolf <address@hidden> writes:

> Commit 70ff5b07 wanted to move the diff between actual and reference
> output to the end after printing the test result line. It really only
> copied it, though, so the diff is now displayed twice. Remove the old
> one.
>
> Fixes: 70ff5b07fcdd378180ad2d5cc0b0d5e67e7ef325
> Signed-off-by: Kevin Wolf <address@hidden>

Queued to testing/next, thanks.

> ---
>  tests/qemu-iotests/check | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
> index 95162c6cf9..44ebf24080 100755
> --- a/tests/qemu-iotests/check
> +++ b/tests/qemu-iotests/check
> @@ -876,7 +876,6 @@ do
>                      fi
>                  else
>                      mv $tmp.out $seq.out.bad
> -                    $diff -w "$reference" "$PWD"/$seq.out.bad
>                      status="fail"
>                      results="output mismatch (see $seq.out.bad)"
>                      printdiff=true


--
Alex Bennée



reply via email to

[Prev in Thread] Current Thread [Next in Thread]