[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target/ppc: Use tcg_gen_gvec_bitsel
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [PATCH] target/ppc: Use tcg_gen_gvec_bitsel |
Date: |
Tue, 4 Jun 2019 11:21:48 +1000 |
User-agent: |
Mutt/1.11.4 (2019-03-13) |
On Mon, Jun 03, 2019 at 11:49:27AM -0500, Richard Henderson wrote:
> Replace the target-specific implementation of XXSEL.
Applied, thanks.
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> target/ppc/translate/vsx-impl.inc.c | 24 ++----------------------
> 1 file changed, 2 insertions(+), 22 deletions(-)
>
> diff --git a/target/ppc/translate/vsx-impl.inc.c
> b/target/ppc/translate/vsx-impl.inc.c
> index 199d22da97..a7a0a88975 100644
> --- a/target/ppc/translate/vsx-impl.inc.c
> +++ b/target/ppc/translate/vsx-impl.inc.c
> @@ -1338,28 +1338,8 @@ static void glue(gen_, name)(DisasContext *ctx)
> \
> VSX_XXMRG(xxmrghw, 1)
> VSX_XXMRG(xxmrglw, 0)
>
> -static void xxsel_i64(TCGv_i64 t, TCGv_i64 a, TCGv_i64 b, TCGv_i64 c)
> -{
> - tcg_gen_and_i64(b, b, c);
> - tcg_gen_andc_i64(a, a, c);
> - tcg_gen_or_i64(t, a, b);
> -}
> -
> -static void xxsel_vec(unsigned vece, TCGv_vec t, TCGv_vec a,
> - TCGv_vec b, TCGv_vec c)
> -{
> - tcg_gen_and_vec(vece, b, b, c);
> - tcg_gen_andc_vec(vece, a, a, c);
> - tcg_gen_or_vec(vece, t, a, b);
> -}
> -
> static void gen_xxsel(DisasContext *ctx)
> {
> - static const GVecGen4 g = {
> - .fni8 = xxsel_i64,
> - .fniv = xxsel_vec,
> - .vece = MO_64,
> - };
> int rt = xT(ctx->opcode);
> int ra = xA(ctx->opcode);
> int rb = xB(ctx->opcode);
> @@ -1369,8 +1349,8 @@ static void gen_xxsel(DisasContext *ctx)
> gen_exception(ctx, POWERPC_EXCP_VSXU);
> return;
> }
> - tcg_gen_gvec_4(vsr_full_offset(rt), vsr_full_offset(ra),
> - vsr_full_offset(rb), vsr_full_offset(rc), 16, 16, &g);
> + tcg_gen_gvec_bitsel(MO_64, vsr_full_offset(rt), vsr_full_offset(rc),
> + vsr_full_offset(rb), vsr_full_offset(ra), 16, 16);
> }
>
> static void gen_xxspltw(DisasContext *ctx)
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature