Re: [Qemu-devel] [PATCH] decodetree: Fix comparison of Field

[Peter Maydell]

On Tue, 4 Jun 2019 at 16:42, Richard Henderson
<address@hidden> wrote:
>
> Typo comparing the sign of the field, twice, instead of also comparing
> the mask of the field (which itself encodes both position and length).
>
> Reported-by: Peter Maydell <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>  scripts/decodetree.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/decodetree.py b/scripts/decodetree.py
> index 81874e22cc..d7a59d63ac 100755
> --- a/scripts/decodetree.py
> +++ b/scripts/decodetree.py
> @@ -184,7 +184,7 @@ class Field:
>          return '{0}(insn, {1}, {2})'.format(extr, self.pos, self.len)
>
>      def __eq__(self, other):
> -        return self.sign == other.sign and self.sign == other.sign
> +        return self.sign == other.sign and self.mask == other.mask
>
>      def __ne__(self, other):
>          return not self.__eq__(other)
> --

Reviewed-by: Peter Maydell <address@hidden>

This fixes the problems I was seeing with the VFP decodetree
conversion I was working on.

thanks
-- PMM