[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 10/12] block/qcow2: refactor qcow2_co_preadv to u
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[Qemu-devel] [PATCH v2 10/12] block/qcow2: refactor qcow2_co_preadv to use buffer-based io |
Date: |
Tue, 4 Jun 2019 19:15:12 +0300 |
Use buffer based io in encrypted case.
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
---
block/qcow2.c | 28 ++++++++++++++++------------
1 file changed, 16 insertions(+), 12 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index f2cb131048..8a033ae08c 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -2047,19 +2047,15 @@ static coroutine_fn int
qcow2_co_preadv(BlockDriverState *bs, uint64_t offset,
}
assert(cur_bytes <= QCOW_MAX_CRYPT_CLUSTERS * s->cluster_size);
- qemu_iovec_reset(&hd_qiov);
- qemu_iovec_add(&hd_qiov, cluster_data, cur_bytes);
- }
- BLKDBG_EVENT(bs->file, BLKDBG_READ_AIO);
- ret = bdrv_co_preadv(s->data_file,
- cluster_offset + offset_in_cluster,
- cur_bytes, &hd_qiov, 0);
- if (ret < 0) {
- goto fail;
- }
- if (bs->encrypted) {
- assert(s->crypto);
+ BLKDBG_EVENT(bs->file, BLKDBG_READ_AIO);
+ ret = bdrv_co_pread(s->data_file,
+ cluster_offset + offset_in_cluster,
+ cur_bytes, cluster_data, 0);
+ if (ret < 0) {
+ goto fail;
+ }
+
assert((offset & (BDRV_SECTOR_SIZE - 1)) == 0);
assert((cur_bytes & (BDRV_SECTOR_SIZE - 1)) == 0);
if (qcow2_co_decrypt(bs, cluster_offset, offset,
@@ -2068,6 +2064,14 @@ static coroutine_fn int qcow2_co_preadv(BlockDriverState
*bs, uint64_t offset,
goto fail;
}
qemu_iovec_from_buf(qiov, bytes_done, cluster_data, cur_bytes);
+ } else {
+ BLKDBG_EVENT(bs->file, BLKDBG_READ_AIO);
+ ret = bdrv_co_preadv(s->data_file,
+ cluster_offset + offset_in_cluster,
+ cur_bytes, &hd_qiov, 0);
+ if (ret < 0) {
+ goto fail;
+ }
}
break;
--
2.18.0
- [Qemu-devel] [PATCH v2 00/12] block: qiov_offset parameter for io, Vladimir Sementsov-Ogievskiy, 2019/06/04
- [Qemu-devel] [PATCH v2 12/12] block/qcow2: implement .bdrv_co_pwritev(_compressed)_part, Vladimir Sementsov-Ogievskiy, 2019/06/04
- [Qemu-devel] [PATCH v2 08/12] block/io: bdrv_aligned_pwritev: use and support qiov_offset, Vladimir Sementsov-Ogievskiy, 2019/06/04
- [Qemu-devel] [PATCH v2 10/12] block/qcow2: refactor qcow2_co_preadv to use buffer-based io,
Vladimir Sementsov-Ogievskiy <=
- [Qemu-devel] [PATCH v2 07/12] block/io: bdrv_aligned_preadv: use and support qiov_offset, Vladimir Sementsov-Ogievskiy, 2019/06/04
- [Qemu-devel] [PATCH v2 04/12] block: define .*_part io handlers in BlockDriver, Vladimir Sementsov-Ogievskiy, 2019/06/04
- [Qemu-devel] [PATCH v2 05/12] block/io: bdrv_co_do_copy_on_readv: use and support qiov_offset, Vladimir Sementsov-Ogievskiy, 2019/06/04
- [Qemu-devel] [PATCH v2 03/12] block/io: refactor padding, Vladimir Sementsov-Ogievskiy, 2019/06/04
- [Qemu-devel] [PATCH v2 11/12] block/qcow2: implement .bdrv_co_preadv_part, Vladimir Sementsov-Ogievskiy, 2019/06/04
- [Qemu-devel] [PATCH v2 09/12] block/io: introduce bdrv_co_p{read, write}v_part, Vladimir Sementsov-Ogievskiy, 2019/06/04
- [Qemu-devel] [PATCH v2 06/12] block/io: bdrv_co_do_copy_on_readv: lazy allocation, Vladimir Sementsov-Ogievskiy, 2019/06/04
- [Qemu-devel] [PATCH v2 02/12] util/iov: improve qemu_iovec_is_zero, Vladimir Sementsov-Ogievskiy, 2019/06/04
- [Qemu-devel] [PATCH v2 01/12] util/iov: introduce qemu_iovec_init_extended, Vladimir Sementsov-Ogievskiy, 2019/06/04