Re: [Qemu-devel] [PULL v2 00/14] virtio, pci, pc: cleanups, features

[Michael S. Tsirkin]

On Tue, Jun 04, 2019 at 04:57:00PM +0100, Peter Maydell wrote:
> On Mon, 3 Jun 2019 at 19:08, Michael S. Tsirkin <address@hidden> wrote:
> >
> > The following changes since commit 8c1ecb590497b0349c550607db923972b37f6963:
> >
> >   Merge remote-tracking branch 
> > 'remotes/stsquad/tags/pull-testing-next-280519-2' into staging (2019-05-28 
> > 17:38:32 +0100)
> >
> > are available in the Git repository at:
> >
> >   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
> >
> > for you to fetch changes up to df7cafdeb68b6572fa81d2be9a1910547c4dfafc:
> >
> >   bios-tables-test: list all tables that differ (2019-06-03 08:05:43 -0400)
> >
> > ----------------------------------------------------------------
> > virtio, pci, pc: cleanups, features
> >
> > stricter rules for acpi tables: we now fail
> > on any difference that isn't whitelisted.
> >
> > vhost-scsi migration.
> >
> > some cleanups all over the place
> >
> > Signed-off-by: Michael S. Tsirkin <address@hidden>
> >
> > ----------------------------------------------------------------
> 
> 
> Hi; I'm afraid this fails 'make check' on my aarch32 build:
> 
> MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
> QTEST_QEMU_BINARY=i386-softmmu/qemu-system-i386
> QTEST_QEMU_IMG=qemu-img tests/bios-tables-test -m=quick -k --tap <
> /dev/null | ./scripts/tap-driver.pl --test-name="bios-tables-test"
> 
> Looking for expected file 'tests/data/acpi/pc/FACP'
> Using expected file 'tests/data/acpi/pc/FACP'
> Looking for expected file 'tests/data/acpi/pc/APIC'
> Using expected file 'tests/data/acpi/pc/APIC'
> Looking for expected file 'tests/data/acpi/pc/HPET'
> Using expected file 'tests/data/acpi/pc/HPET'
> Looking for expected file 'tests/data/acpi/pc/FACS'
> Using expected file 'tests/data/acpi/pc/FACS'
> Looking for expected file 'tests/data/acpi/pc/DSDT'
> Using expected file 'tests/data/acpi/pc/DSDT'
> PASS 1 bios-tables-test /i386/acpi/piix4
> 
> Looking for expected file 'tests/data/acpi/q35/FACP'
> Using expected file 'tests/data/acpi/q35/FACP'
> Looking for expected file 'tests/data/acpi/q35/APIC'
> Using expected file 'tests/data/acpi/q35/APIC'
> Looking for expected file 'tests/data/acpi/q35/HPET'
> Using expected file 'tests/data/acpi/q35/HPET'
> Looking for expected file 'tests/data/acpi/q35/MCFG'
> Using expected file 'tests/data/acpi/q35/MCFG'
> Looking for expected file 'tests/data/acpi/q35/FACS'
> Using expected file 'tests/data/acpi/q35/FACS'
> Looking for expected file 'tests/data/acpi/q35/DSDT'
> Using expected file 'tests/data/acpi/q35/DSDT'
> acpi-test: Warning! DSDT mismatch. Actual [asl:/tmp/asl-NKUU2Z.dsl,
> aml:/tmp/aml-UERV2Z], Expected [asl:/tmp/asl-3ITW2Z.dsl,
> aml:tests/data/acpi/q35/DSDT].
> acpi-test: Warning. not showing difference since no diff utility is
> specified. Set 'DIFF' environment variable to a preferred diff utility
> and run 'make V=1 check' again to see ASL difference.**
> ERROR:/home/peter.maydell/qemu/tests/bios-tables-test.c:422:test_acpi_asl:
> assertion failed: (all_tables_match)
> Aborted
> ERROR - too few tests run (expected 15, got 1)
> /home/peter.maydell/qemu/tests/Makefile.include:884: recipe for target
> 'check-qtest-i386' failed
> 
> 
> This is the only 32-bit host I test on, so it may be a generic
> 32-bit host problem rather than arm-specific.
> 
> thanks
> -- PMM

I see. I can drop this patch for now, but I suspect this
means this host always produced warning and possibly
that the tables are all wrong.
Could you send me the actual and expected files please?
Preferably both dsl and binary.

-- 
MST