[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Headers without multiple inclusion guards
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] Headers without multiple inclusion guards |
Date: |
Wed, 05 Jun 2019 19:52:50 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Daniel P. Berrangé <address@hidden> writes:
> On Tue, May 28, 2019 at 08:12:24PM +0200, Markus Armbruster wrote:
>> We have a bunch of headers without multiple inclusion guards. Some are
>> clearly intentional, some look accidental. Too many for me to find out
>> by examining each of them, so I'm asking their maintainers.
>>
>> Why do I ask? I'd like to mark the intentional ones and fix the
>> accidental ones, so they don't flunk "make check-headers" from "[RFC v4
>> 0/7] Baby steps towards saner headers" just because they lack multiple
>> inclusion guards.
>>
>> Just in case: what's a multiple inclusion guard? It's
>>
>> #ifndef UNIQUE_GUARD_SYMBOL_H
>> #define UNIQUE_GUARD_SYMBOL_H
>> ...
>> #endif
>>
>> with nothing but comments outside the conditional, so that the header
>> can safely be included more than once.
>
> Any opinions on using the less verbose syntax instead:
>
> #pragma once
>
> It is not portable C, but we explicitly only care about GCC or CLang,
> so portability isn't an issue for us.
I doubt its worth the churn. But I'm content to go with the flow here.
>> Cryptography
>> M: Daniel P. Berrange <address@hidden>
>> crypto/ivgen-essiv.h
>> crypto/ivgen-plain.h
>> crypto/ivgen-plain64.h
>
> These have header guards present
Yes. They #include outside the header guard, which confuses my script.
>> tests/crypto-tls-psk-helpers.h
>> tests/crypto-tls-x509-helpers.h
>
> These should be fixed.
Will do, thanks!
Re: [Qemu-devel] Headers without multiple inclusion guards, Alistair Francis, 2019/06/05