[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 09/16] hw/s390x/event-facility: Use the QOM BUS()
From: |
David Hildenbrand |
Subject: |
Re: [Qemu-devel] [PULL 09/16] hw/s390x/event-facility: Use the QOM BUS() macro to access BusState.qbus |
Date: |
Thu, 6 Jun 2019 14:11:57 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 06.06.19 13:06, Laurent Vivier wrote:
> From: Philippe Mathieu-Daudé <address@hidden>
>
> Rather than looking inside the definition of a BusState with "s->bus.qbus",
> use the QOM prefered style: "BUS(&s->bus)".
>
> This patch was generated using the following Coccinelle script:
>
> // Use BUS() macros to access BusState.qbus
> @use_bus_macro_to_access_qbus@
> expression obj;
> identifier bus;
> @@
> -&obj->bus.qbus
> +BUS(&obj->bus)
>
> Suggested-by: Peter Maydell <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> Reviewed-by: Cornelia Huck <address@hidden>
> Message-Id: <address@hidden>
> Signed-off-by: Laurent Vivier <address@hidden>
> ---
> hw/s390x/event-facility.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/s390x/event-facility.c b/hw/s390x/event-facility.c
> index ee5b83448b11..e574223a226b 100644
> --- a/hw/s390x/event-facility.c
> +++ b/hw/s390x/event-facility.c
> @@ -466,12 +466,12 @@ static void init_event_facility(Object *obj)
> new = object_new(TYPE_SCLP_QUIESCE);
> object_property_add_child(obj, TYPE_SCLP_QUIESCE, new, NULL);
> object_unref(new);
> - qdev_set_parent_bus(DEVICE(new), &event_facility->sbus.qbus);
> + qdev_set_parent_bus(DEVICE(new), BUS(&event_facility->sbus));
>
> new = object_new(TYPE_SCLP_CPU_HOTPLUG);
> object_property_add_child(obj, TYPE_SCLP_CPU_HOTPLUG, new, NULL);
> object_unref(new);
> - qdev_set_parent_bus(DEVICE(new), &event_facility->sbus.qbus);
> + qdev_set_parent_bus(DEVICE(new), BUS(&event_facility->sbus));
> /* the facility will automatically realize the devices via the bus */
> }
>
>
Reviewed-by: David Hildenbrand <address@hidden>
--
Thanks,
David / dhildenb
- [Qemu-devel] [PULL 00/16] Trivial branch patches, Laurent Vivier, 2019/06/06
- [Qemu-devel] [PULL 07/16] hw/scsi/vmw_pvscsi: Use qbus_reset_all() directly, Laurent Vivier, 2019/06/06
- [Qemu-devel] [PULL 06/16] docs/devel/build-system: Update an example, Laurent Vivier, 2019/06/06
- [Qemu-devel] [PULL 11/16] hw/usb-storage: Use the QOM DEVICE() macro to access DeviceState.qdev, Laurent Vivier, 2019/06/06
- [Qemu-devel] [PULL 03/16] vhost: fix incorrect print type, Laurent Vivier, 2019/06/06
- [Qemu-devel] [PULL 08/16] hw/pci-bridge: Use the QOM BUS() macro to access BusState.qbus, Laurent Vivier, 2019/06/06
- [Qemu-devel] [PULL 04/16] util: Adjust qemu_guest_getrandom_nofail for Coverity, Laurent Vivier, 2019/06/06
- [Qemu-devel] [PULL 13/16] hw/audio/ac97: Use the QOM DEVICE() macro to access DeviceState.qdev, Laurent Vivier, 2019/06/06
- [Qemu-devel] [PULL 09/16] hw/s390x/event-facility: Use the QOM BUS() macro to access BusState.qbus, Laurent Vivier, 2019/06/06
- Re: [Qemu-devel] [PULL 09/16] hw/s390x/event-facility: Use the QOM BUS() macro to access BusState.qbus,
David Hildenbrand <=
- [Qemu-devel] [PULL 05/16] test: Fix make target check-report.tap, Laurent Vivier, 2019/06/06
- [Qemu-devel] [PULL 16/16] hw/watchdog/wdt_i6300esb: Use DEVICE() macro to access DeviceState.qdev, Laurent Vivier, 2019/06/06
- [Qemu-devel] [PULL 14/16] hw/sd: Use the QOM BUS() macro to access BusState.qbus, Laurent Vivier, 2019/06/06
- [Qemu-devel] [PULL 01/16] hw/rdma: Delete unused headers inclusion, Laurent Vivier, 2019/06/06
- [Qemu-devel] [PULL 10/16] hw/isa: Use the QOM DEVICE() macro to access DeviceState.qdev, Laurent Vivier, 2019/06/06
- [Qemu-devel] [PULL 15/16] hw/scsi: Use the QOM BUS() macro to access BusState.qbus, Laurent Vivier, 2019/06/06
- [Qemu-devel] [PULL 12/16] hw/vfio/pci: Use the QOM DEVICE() macro to access DeviceState.qdev, Laurent Vivier, 2019/06/06
- [Qemu-devel] [PULL 02/16] migration: fix a typo, Laurent Vivier, 2019/06/06
- Re: [Qemu-devel] [PULL 00/16] Trivial branch patches, Peter Maydell, 2019/06/06