[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/5] tricore: reset DisasContext before generati
From: |
Bastian Koppelmann |
Subject: |
Re: [Qemu-devel] [PATCH 5/5] tricore: reset DisasContext before generating code |
Date: |
Thu, 6 Jun 2019 16:24:43 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
Hi Georg,
On 6/6/19 1:44 PM, Hofstetter, Georg (EFS-GH2) wrote:
Hi Sebastian,
in translate.c:gen_mtcr() code accesses hflags within the structure:
if ((ctx->hflags & TRICORE_HFLAG_KUU) == TRICORE_HFLAG_SM) {
/* since we're caching PSW make this a special case */
The code expects the HFLAG set for kernel mode in (i guess) preparation for
supporting operation modes.
There is no code modifying these flags.
The flags were introduced in 0aaeb11 and there it looks like it was expected to
be zeroed - maybe you know a bit more.
Yep, the ctx->hflags is supposed to be synced by tb->flags (which is
normally synced with CPUTriCoreState via cpu_get_tb_cpu_state()) in
gen_intermediate_code(). Somehow I forgot to add the first sync. So, the
proper fix is:
diff --git a/target/tricore/translate.c b/target/tricore/translate.c
index 06c4485e55..44296b3fb1 100644
--- a/target/tricore/translate.c
+++ b/target/tricore/translate.c
@@ -8804,6 +8804,7 @@ void gen_intermediate_code(CPUState *cs,
TranslationBlock *tb, int max_insns)
ctx.singlestep_enabled = cs->singlestep_enabled;
ctx.bstate = BS_NONE;
ctx.mem_idx = cpu_mmu_index(env, false);
+ ctx.hflags = (uint32_t)tb->flags;
tcg_clear_temp_count();
gen_tb_start(tb);
Cheers,
Bastian
- [Qemu-devel] [PATCH 0/5] tricore: adding new instructions and fixing issues, David Brenken, 2019/06/05
- [Qemu-devel] [PATCH 3/5] tricore: fix RRPW_INSERT instruction, David Brenken, 2019/06/05
- Re: [Qemu-devel] [PATCH 3/5] tricore: fix RRPW_INSERT instruction, Bastian Koppelmann, 2019/06/05
- Re: [Qemu-devel] [PATCH 3/5] tricore: fix RRPW_INSERT instruction, Brenken, David (EFS-GH2), 2019/06/06
- Re: [Qemu-devel] [PATCH 3/5] tricore: fix RRPW_INSERT instruction, Richard Henderson, 2019/06/07
- Re: [Qemu-devel] [PATCH 3/5] tricore: fix RRPW_INSERT instruction, Brenken, David (EFS-GH2), 2019/06/12
- Re: [Qemu-devel] [PATCH 3/5] tricore: fix RRPW_INSERT instruction, Bastian Koppelmann, 2019/06/12
[Qemu-devel] [PATCH 1/5] tricore: add FTOIZ instruction, David Brenken, 2019/06/05
Re: [Qemu-devel] [PATCH 0/5] tricore: adding new instructions and fixing issues, Bastian Koppelmann, 2019/06/05