[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 38/39] tcg/arm: Use LDRD to load tlb mask+tab
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v4 38/39] tcg/arm: Use LDRD to load tlb mask+table |
Date: |
Fri, 7 Jun 2019 11:24:54 +0100 |
On Tue, 4 Jun 2019 at 22:08, Richard Henderson
<address@hidden> wrote:
>
> This changes the code generation for the tlb from e.g.
>
> ldr ip, [r6, #-0x10]
> ldr r2, [r6, #-0xc]
> and ip, ip, r4, lsr #8
> ldrd r0, r1, [r2, ip]!
> ldr r2, [r2, #0x18]
>
> to
>
> ldrd r0, r1, [r6, #-0x10]
> and r0, r0, r4, lsr #8
> ldrd r2, r3, [r1, r0]!
> ldr r1, [r1, #0x18]
>
> for armv7 hosts. Rearranging the register allocation in
> order to avoid overlap between the two ldrd pairs causes
> the patch to be larger than it ordinarily would be.
>
> Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- [Qemu-devel] [PATCH v4 29/39] target/unicore32: Use env_cpu, env_archcpu, (continued)
- [Qemu-devel] [PATCH v4 29/39] target/unicore32: Use env_cpu, env_archcpu, Richard Henderson, 2019/06/04
- [Qemu-devel] [PATCH v4 30/39] target/xtensa: Use env_cpu, env_archcpu, Richard Henderson, 2019/06/04
- [Qemu-devel] [PATCH v4 32/39] cpu: Introduce cpu_set_cpustate_pointers, Richard Henderson, 2019/06/04
- [Qemu-devel] [PATCH v4 31/39] cpu: Move ENV_OFFSET to exec/gen-icount.h, Richard Henderson, 2019/06/04
- [Qemu-devel] [PATCH v4 33/39] cpu: Introduce CPUNegativeOffsetState, Richard Henderson, 2019/06/04
- [Qemu-devel] [PATCH v4 34/39] cpu: Move icount_decr to CPUNegativeOffsetState, Richard Henderson, 2019/06/04
- [Qemu-devel] [PATCH v4 36/39] cpu: Remove CPU_COMMON, Richard Henderson, 2019/06/04
- [Qemu-devel] [PATCH v4 35/39] cpu: Move the softmmu tlb to CPUNegativeOffsetState, Richard Henderson, 2019/06/04
- [Qemu-devel] [PATCH v4 39/39] tcg/arm: Remove mostly unreachable tlb special case, Richard Henderson, 2019/06/04
- [Qemu-devel] [PATCH v4 38/39] tcg/arm: Use LDRD to load tlb mask+table, Richard Henderson, 2019/06/04
- Re: [Qemu-devel] [PATCH v4 38/39] tcg/arm: Use LDRD to load tlb mask+table,
Peter Maydell <=
- [Qemu-devel] [PATCH v4 37/39] tcg/aarch64: Use LDP to load tlb mask+table, Richard Henderson, 2019/06/04
- Re: [Qemu-devel] [PATCH v4 00/39] tcg: Move the softmmu tlb to CPUNegativeOffsetState, no-reply, 2019/06/04
- Re: [Qemu-devel] [PATCH v4 00/39] tcg: Move the softmmu tlb to CPUNegativeOffsetState, no-reply, 2019/06/04
- Re: [Qemu-devel] [PATCH v4 00/39] tcg: Move the softmmu tlb to CPUNegativeOffsetState, no-reply, 2019/06/04