|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [PATCH 12/42] target/arm: Convert "double-precision" register moves to decodetree |
Date: | Fri, 7 Jun 2019 12:27:59 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 6/6/19 12:45 PM, Peter Maydell wrote: > Convert the "double-precision" register moves to decodetree: > this covers VMOV scalar-to-gpreg, VMOV gpreg-to-scalar and VDUP. > > Note that the conversion process has tightened up a few of the > UNDEF encoding checks: we now correctly forbid: > * VMOV-to-gpr with U:opc1:opc2 == 10x00 or x0x10 > * VMOV-from-gpr with opc1:opc2 == 0x10 > * VDUP with B:E == 11 > * VDUP with Q == 1 and Vn<0> == 1 > > Signed-off-by: Peter Maydell <address@hidden> > --- > The accesses of elements < 32 bits could be improved by doing > direct ld/st of the right size rather than 32-bit read-and-shift > or read-modify-write, but we leave this for later cleanup, > since this series is generally trying to stick to fixing > the decode. > -- Reviewed-by: Richard Henderson <address@hidden> r~
[Prev in Thread] | Current Thread | [Next in Thread] |