Re: [Qemu-devel] [PULL 00/39] tcg: Move the softmmu tlb to CPUNegativeOffsetState

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PULL 00/39] tcg: Move the softmmu tlb to 
CPUNegativeOffsetState
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
4b2d8c1852 tcg/arm: Remove mostly unreachable tlb special case
9ecc19856b tcg/arm: Use LDRD to load tlb mask+table
0a1acd1819 tcg/aarch64: Use LDP to load tlb mask+table
6abcfb2558 cpu: Remove CPU_COMMON
21a4bf85d4 cpu: Move the softmmu tlb to CPUNegativeOffsetState
021b2afde4 cpu: Move icount_decr to CPUNegativeOffsetState
d0c256020b cpu: Introduce CPUNegativeOffsetState
4c80796547 cpu: Introduce cpu_set_cpustate_pointers
0fcf981cc1 cpu: Move ENV_OFFSET to exec/gen-icount.h
17cfb5d985 target/xtensa: Use env_cpu, env_archcpu
7ee3bc9bd1 target/unicore32: Use env_cpu, env_archcpu
a301882a16 target/tricore: Use env_cpu
d6ef28fa1b target/tilegx: Use env_cpu
5edf437d93 target/sparc: Use env_cpu, env_archcpu
538159664b target/sh4: Use env_cpu, env_archcpu
ad29065402 target/s390x: Use env_cpu, env_archcpu
cb71790e74 target/riscv: Use env_cpu, env_archcpu
6d7d100ed9 target/ppc: Use env_cpu, env_archcpu
05e58e0d8a target/openrisc: Use env_cpu, env_archcpu
2519b0c65a target/nios2: Use env_cpu, env_archcpu
112e818bbf target/moxie: Use env_cpu, env_archcpu
226eddd70b target/mips: Use env_cpu, env_archcpu
842cea8308 target/microblaze: Use env_cpu, env_archcpu
81cfd37e1d target/m68k: Use env_cpu
2fc6727a54 target/lm32: Use env_cpu, env_archcpu
b20070a6ae target/i386: Use env_cpu, env_archcpu
2bc3043044 target/hppa: Use env_cpu, env_archcpu
650c41d2c8 target/cris: Use env_cpu, env_archcpu
9f08ae13f5 target/cris: Reindent op_helper.c
1e27218635 target/cris: Reindent mmu.c
2b235e47e0 target/arm: Use env_cpu, env_archcpu
d433803411 target/alpha: Use env_cpu, env_archcpu
a91011c10f cpu: Introduce env_archcpu
6d78f2fc03 cpu: Replace ENV_GET_CPU with env_cpu
83019014e3 cpu: Define ArchCPU
4c25215e81 cpu: Define CPUArchState with typedef
6f012104e2 tcg: Create struct CPUTLB
4af2bea36a tcg: Split out target/arch/cpu-param.h
65f7a0658b tcg: Fold CPUTLBWindow into CPUTLBDesc

=== OUTPUT BEGIN ===
1/39 Checking commit 65f7a0658b81 (tcg: Fold CPUTLBWindow into CPUTLBDesc)
2/39 Checking commit 4af2bea36ac9 (tcg: Split out target/arch/cpu-param.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#57: 
new file mode 100644

total: 0 errors, 1 warnings, 1290 lines checked

Patch 2/39 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/39 Checking commit 6f012104e214 (tcg: Create struct CPUTLB)
4/39 Checking commit 4c25215e81ff (cpu: Define CPUArchState with typedef)
5/39 Checking commit 83019014e305 (cpu: Define ArchCPU)
6/39 Checking commit 6d78f2fc03f0 (cpu: Replace ENV_GET_CPU with env_cpu)
7/39 Checking commit a91011c10f10 (cpu: Introduce env_archcpu)
8/39 Checking commit d4338034117c (target/alpha: Use env_cpu, env_archcpu)
9/39 Checking commit 2b235e47e090 (target/arm: Use env_cpu, env_archcpu)
10/39 Checking commit 1e27218635a6 (target/cris: Reindent mmu.c)
11/39 Checking commit 9f08ae13f592 (target/cris: Reindent op_helper.c)
12/39 Checking commit 650c41d2c8ff (target/cris: Use env_cpu, env_archcpu)
13/39 Checking commit 2bc3043044e1 (target/hppa: Use env_cpu, env_archcpu)
14/39 Checking commit b20070a6ae29 (target/i386: Use env_cpu, env_archcpu)
15/39 Checking commit 2fc6727a54eb (target/lm32: Use env_cpu, env_archcpu)
16/39 Checking commit 81cfd37e1d7e (target/m68k: Use env_cpu)
17/39 Checking commit 842cea830816 (target/microblaze: Use env_cpu, env_archcpu)
18/39 Checking commit 226eddd70bc3 (target/mips: Use env_cpu, env_archcpu)
19/39 Checking commit 112e818bbf61 (target/moxie: Use env_cpu, env_archcpu)
20/39 Checking commit 2519b0c65a54 (target/nios2: Use env_cpu, env_archcpu)
21/39 Checking commit 05e58e0d8aa3 (target/openrisc: Use env_cpu, env_archcpu)
22/39 Checking commit 6d7d100ed9ad (target/ppc: Use env_cpu, env_archcpu)
23/39 Checking commit cb71790e7474 (target/riscv: Use env_cpu, env_archcpu)
24/39 Checking commit ad29065402f2 (target/s390x: Use env_cpu, env_archcpu)
25/39 Checking commit 538159664b94 (target/sh4: Use env_cpu, env_archcpu)
26/39 Checking commit 5edf437d93d3 (target/sparc: Use env_cpu, env_archcpu)
27/39 Checking commit d6ef28fa1b69 (target/tilegx: Use env_cpu)
28/39 Checking commit a301882a162f (target/tricore: Use env_cpu)
29/39 Checking commit 7ee3bc9bd117 (target/unicore32: Use env_cpu, env_archcpu)
30/39 Checking commit 17cfb5d98571 (target/xtensa: Use env_cpu, env_archcpu)
31/39 Checking commit 0fcf981cc166 (cpu: Move ENV_OFFSET to exec/gen-icount.h)
32/39 Checking commit 4c8079654779 (cpu: Introduce cpu_set_cpustate_pointers)
33/39 Checking commit d0c256020b90 (cpu: Introduce CPUNegativeOffsetState)
34/39 Checking commit 021b2afde43d (cpu: Move icount_decr to 
CPUNegativeOffsetState)
ERROR: return is not a function, parentheses are not required
#193: FILE: cpus.c:242:
+    return (cpu->icount_budget -

total: 1 errors, 0 warnings, 326 lines checked

Patch 34/39 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

35/39 Checking commit 21a4bf85d478 (cpu: Move the softmmu tlb to 
CPUNegativeOffsetState)
36/39 Checking commit 6abcfb2558b4 (cpu: Remove CPU_COMMON)
37/39 Checking commit 0a1acd1819a7 (tcg/aarch64: Use LDP to load tlb mask+table)
38/39 Checking commit 9ecc19856bc8 (tcg/arm: Use LDRD to load tlb mask+table)
39/39 Checking commit 4b2d8c1852c9 (tcg/arm: Remove mostly unreachable tlb 
special case)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden