[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 06/15] target/ppc: introduce separate generat
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v2 06/15] target/ppc: introduce separate generator and helper for xscvqpdp |
Date: |
Wed, 12 Jun 2019 13:04:10 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 6/2/19 4:08 AM, Mark Cave-Ayland wrote:
> Rather than perform the VSR register decoding within the helper itself,
> introduce a new generator and helper function which perform the decode based
> upon xT and xB at translation time.
>
> The xscvqpdp helper is the only 2 parameter xT/xB implementation that requires
> the opcode to be passed as an additional parameter, so handling this
> separately
> allows us to optimise the conversion in the next commit.
>
> Signed-off-by: Mark Cave-Ayland <address@hidden>
> ---
> target/ppc/fpu_helper.c | 5 ++---
> target/ppc/helper.h | 2 +-
> target/ppc/translate/vsx-impl.inc.c | 18 +++++++++++++++++-
> 3 files changed, 20 insertions(+), 5 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
[Qemu-devel] [PATCH v2 02/15] target/ppc: remove getVSR()/putVSR() from mem_helper.c, Mark Cave-Ayland, 2019/06/02