[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH qemu v2] hmp: Print if memory section is registe
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH qemu v2] hmp: Print if memory section is registered with an accelerator |
Date: |
Thu, 13 Jun 2019 16:04:40 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 13/06/19 07:07, Alexey Kardashevskiy wrote:
> + if (as == &address_space_memory) {
> + system_as = true;
> + }
> }
Ah no, wait... On x86, there are two KVM address spaces, so you have to
pass "as" to has_memory. To detect KVM address spaces, you can allocate
an array with kvm_check_extension(kvm, KVM_CAP_MULTI_ADDRESS_SPACE)
elements (default 1 if the capability is not available), and fill it in
kvm_memory_listener_register. Then you an search for the address space
in that array, it's very small and cheap.
Promise to merge quickly with that change.
Thanks,
Paolo