Re: [Qemu-devel] [PATCH v9] ssh: switch from libssh2 to libssh

[Eric Blake]

On 6/13/19 2:31 PM, Max Reitz wrote:

>> @@ -657,71 +644,147 @@ static int connect_to_ssh(BDRVSSHState *s, 
>> BlockdevOptionsSsh *opts,
> 
> [...]
> 
>> +    /*
>> +     * Try to disable the Nagle algorithm on TCP sockets to reduce latency,
>> +     * but do not fail if it cannot be disabled.
>> +     */
>> +    r = socket_set_nodelay(new_sock);
>> +    if (r < 0) {
>> +        warn_report("setting NODELAY for the ssh server %s failed: %m",
> 
> TIL about %m.

printf("%m") is not portable to non-glibc. Spell it out as
"%s",strerror(errno).  (It _is_ portable for syslog(), but warn_report()
is not wired to syslog() semantics).

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature