[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 5/6] migration: Make no compression operation
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH v4 5/6] migration: Make no compression operations into its own structure |
Date: |
Fri, 14 Jun 2019 19:33:34 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
"Dr. David Alan Gilbert" <address@hidden> wrote:
> * Juan Quintela (address@hidden) wrote:
>> It will be used later.
>>
>> Signed-off-by: Juan Quintela <address@hidden>
>> + */
>> +static int nocomp_recv_pages(MultiFDRecvParams *p, uint32_t used, Error
>> **errp)
>> +{
>> + if (p->flags != 0) {
>> + error_setg(errp, "multifd %d: flags received %x flags expected %x",
>> + p->id, MULTIFD_FLAG_ZLIB, p->flags);
>
> Can you just explain that a bit - the 'received' seems to be constant
> while the expected is p->flags - is that the right way around?
> Why would you expect FLAG_ZLIB in nocomp?
When I changed printf's to error_setg I did a bit *too much* of copy
paste. Then I decided to put consistently received/expected in all
messages and clearly I failed.
Fixing, Thanks.
- [Qemu-devel] [PATCH v4 0/6] Multifd compression support, Juan Quintela, 2019/06/12
- [Qemu-devel] [PATCH v4 2/6] migration: Make multifd_save_setup() get an Error parameter, Juan Quintela, 2019/06/12
- [Qemu-devel] [PATCH v4 1/6] migration-test: introduce functions to handle string parameters, Juan Quintela, 2019/06/12
- [Qemu-devel] [PATCH v4 3/6] migration: Make multifd_load_setup() get an Error parameter, Juan Quintela, 2019/06/12
- [Qemu-devel] [PATCH v4 5/6] migration: Make no compression operations into its own structure, Juan Quintela, 2019/06/12
- [Qemu-devel] [PATCH v4 4/6] migration: Add multifd-compress parameter, Juan Quintela, 2019/06/12
- [Qemu-devel] [PATCH v4 6/6] migration: Add zlib compression multifd support, Juan Quintela, 2019/06/12