[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] net: cadence_gem: fix compilation error when
From: |
Ramon Fried |
Subject: |
Re: [Qemu-devel] [PATCH v2] net: cadence_gem: fix compilation error when debug is on |
Date: |
Sat, 15 Jun 2019 08:10:56 +0300 |
On Wed, Jun 12, 2019 at 10:40 AM Laurent Vivier <address@hidden> wrote:
> Le 12/06/2019 à 06:27, Ramon Fried a écrit :
> >
> >
> > On Tue, Jun 11, 2019 at 7:21 PM Laurent Vivier <address@hidden
> > <mailto:address@hidden>> wrote:
> >
> > Le 11/06/2019 à 16:55, Ramon Fried a écrit :
> > > defining CADENCE_GEM_ERR_DEBUG causes compilation
> > > errors, fix that.
> > >
> > > Signed-off-by: Ramon Fried <address@hidden
> > <mailto:address@hidden>>
> > > ---
> > > v2: change %lx to HWADDR_PRIx and %lx to %zdx
> >
> > HWADDR_PRIx is to use with hwaddr type (packet_desc_addr).
> > rx_desc_get_buffer() is uint64_t, you must use PRIx64.
> > It may be better to remove also the cast to unsigned.
> >
> > Other places in the code also use HWADDR_PRIx with rx_desc_get_buffer().
> > Should I change them also ?
>
> No, in fact you should change the return type of rx_desc_get_buffer() to
> hwaddr.
>
Make sense.
I'll do it in a different patch.
>
> Thanks,
> Laurent
>