Re: [Qemu-devel] [PATCH v20 00/24] Add RX archtecture support

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v20 00/24] Add RX archtecture support
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
0c27dd8 BootLinuxConsoleTest: Test the RX-Virt machine
2a6876d MAINTAINERS: Add RX
d251bcb Add rx-softmmu
74589c9 hw/registerfields.h: Add 8bit and 16bit register macros
d79dcb1 qemu/bitops.h: Add extract8 and extract16
7b48c06 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
f57add5 hw/rx: Honor -accel qtest
6250788 target/rx: Move rx_load_image to rx-virt.
7023958 hw/rx: RX Target hardware definition
02ccff2 hw/char: RX62N serial communication interface (SCI)
82f9b2f hw/timer: RX62N internal timer modules
d5bbed0 hw/intc: RX62N interrupt controller (ICUa)
70acbbd target/rx: Dump bytes for each insn during disassembly
2e7845e target/rx: Collect all bytes during disassembly
78b4585 target/rx: Emit all disassembly in one prt()
4f2586f target/rx: Use prt_ldmi for XCHG_mr disassembly
85b4ce9 target/rx: Replace operand with prt_ldmi in disassembler
33933e5 target/rx: Disassemble rx_index_addr into a string
72b9045 target/rx: RX disassembler
8ce563c target/rx: simplify rx_cpu_class_by_name
7f2e05e target/rx: Follow the change of tcg.
065893f target/rx: CPU definition
5f160a0 target/rx: TCG helper
24091fb target/rx: TCG translation

=== OUTPUT BEGIN ===
1/24 Checking commit 24091fb702bb (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 3065 lines checked

Patch 1/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/24 Checking commit 5f160a0c4667 (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 649 lines checked

Patch 2/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/24 Checking commit 065893fc208c (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 645 lines checked

Patch 3/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/24 Checking commit 7f2e05e35322 (target/rx: Follow the change of tcg.)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15: 
new file mode 100644

total: 0 errors, 1 warnings, 121 lines checked

Patch 4/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/24 Checking commit 8ce563cdcaed (target/rx: simplify rx_cpu_class_by_name)
6/24 Checking commit 72b9045c8042 (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 1497 lines checked

Patch 6/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/24 Checking commit 33933e5f814b (target/rx: Disassemble rx_index_addr into a 
string)
8/24 Checking commit 85b4ce969b9f (target/rx: Replace operand with prt_ldmi in 
disassembler)
9/24 Checking commit 4f2586f683be (target/rx: Use prt_ldmi for XCHG_mr 
disassembly)
10/24 Checking commit 78b4585ca396 (target/rx: Emit all disassembly in one 
prt())
11/24 Checking commit 2e7845e0912b (target/rx: Collect all bytes during 
disassembly)
12/24 Checking commit 70acbbdd2844 (target/rx: Dump bytes for each insn during 
disassembly)
13/24 Checking commit d5bbed0bb689 (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

total: 0 errors, 1 warnings, 442 lines checked

Patch 13/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/24 Checking commit 82f9b2f0f2d1 (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 839 lines checked

Patch 14/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/24 Checking commit 02ccff275fb2 (hw/char: RX62N serial communication 
interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
new file mode 100644

total: 0 errors, 1 warnings, 398 lines checked

Patch 15/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/24 Checking commit 70239586c4f4 (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
new file mode 100644

total: 0 errors, 1 warnings, 457 lines checked

Patch 16/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/24 Checking commit 625078837bc8 (target/rx: Move rx_load_image to rx-virt.)
18/24 Checking commit f57add58ea62 (hw/rx: Honor -accel qtest)
19/24 Checking commit 7b48c064789d (hw/rx: Restrict the RX62N microcontroller 
to the RX62N CPU core)
20/24 Checking commit d79dcb1d3979 (qemu/bitops.h: Add extract8 and extract16)
21/24 Checking commit 74589c9da34e (hw/registerfields.h: Add 8bit and 16bit 
register macros)
Use of uninitialized value in concatenation (.) or string at 
./scripts/checkpatch.pl line 2467.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) };

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) / 2 };

total: 2 errors, 0 warnings, 56 lines checked

Patch 21/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

22/24 Checking commit d251bcb5eb98 (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#61: 
new file mode 100644

total: 0 errors, 1 warnings, 73 lines checked

Patch 22/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
23/24 Checking commit 2a6876dc18fd (MAINTAINERS: Add RX)
24/24 Checking commit 0c27dd8686ef (BootLinuxConsoleTest: Test the RX-Virt 
machine)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden