[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Xen-devel] [PATCH 0/4] Fix build of Xen support + clea
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [Xen-devel] [PATCH 0/4] Fix build of Xen support + cleanup |
Date: |
Mon, 17 Jun 2019 11:09:06 -0700 (PDT) |
Patchew URL: https://patchew.org/QEMU/address@hidden/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: address@hidden
Type: series
Subject: [Xen-devel] [PATCH 0/4] Fix build of Xen support + cleanup
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Switched to a new branch 'test'
919708e xen: Avoid VLA
1d20f2a xen: Import Xen public headers used by xen-hvm.c
252595d xen: Import other xen/io/*.h
301a4be xen: Fix build with public headers
=== OUTPUT BEGIN ===
1/4 Checking commit 301a4be9fa06 (xen: Fix build with public headers)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#94:
new file mode 100644
WARNING: Block comments use a leading /* on a separate line
#99: FILE: include/hw/xen/interface/grant_table.h:1:
+/******************************************************************************
WARNING: Block comments use a leading /* on a separate line
#141: FILE: include/hw/xen/interface/io/blkif.h:1:
+/******************************************************************************
ERROR: spaces required around that '<<' (ctx:VxV)
#804: FILE: include/hw/xen/interface/io/blkif.h:664:
+#define BLKIF_DISCARD_SECURE (1<<0) /* ignored if discard-secure=0 */
^
WARNING: architecture specific defines should be avoided
#820: FILE: include/hw/xen/interface/io/blkif.h:680:
+#ifdef __i386__
ERROR: code indent should never use tabs
#967: FILE: include/hw/xen/interface/io/usbif.h:105:
+^IUSB_VER_UNKNOWN = 0,$
ERROR: code indent should never use tabs
#968: FILE: include/hw/xen/interface/io/usbif.h:106:
+^IUSB_VER_USB11,$
ERROR: code indent should never use tabs
#969: FILE: include/hw/xen/interface/io/usbif.h:107:
+^IUSB_VER_USB20,$
ERROR: code indent should never use tabs
#970: FILE: include/hw/xen/interface/io/usbif.h:108:
+^IUSB_VER_USB30,^I/* not supported yet */$
ERROR: code indent should never use tabs
#976: FILE: include/hw/xen/interface/io/usbif.h:114:
+ * - port number:^Ibits 0-4$
ERROR: code indent should never use tabs
#977: FILE: include/hw/xen/interface/io/usbif.h:115:
+ *^I^I^I^I(USB_MAXCHILDREN is 31)$
ERROR: code indent should never use tabs
#979: FILE: include/hw/xen/interface/io/usbif.h:117:
+ * - operation flag:^Ibit 5$
ERROR: code indent should never use tabs
#980: FILE: include/hw/xen/interface/io/usbif.h:118:
+ *^I^I^I^I(0 = submit urb,$
ERROR: code indent should never use tabs
#981: FILE: include/hw/xen/interface/io/usbif.h:119:
+ *^I^I^I^I 1 = unlink urb)$
ERROR: code indent should never use tabs
#983: FILE: include/hw/xen/interface/io/usbif.h:121:
+ * - direction:^I^Ibit 7$
ERROR: code indent should never use tabs
#984: FILE: include/hw/xen/interface/io/usbif.h:122:
+ *^I^I^I^I(0 = Host-to-Device [Out]$
ERROR: code indent should never use tabs
#985: FILE: include/hw/xen/interface/io/usbif.h:123:
+ *^I^I^I^I 1 = Device-to-Host [In])$
ERROR: code indent should never use tabs
#987: FILE: include/hw/xen/interface/io/usbif.h:125:
+ * - device address:^Ibits 8-14$
ERROR: code indent should never use tabs
#989: FILE: include/hw/xen/interface/io/usbif.h:127:
+ * - endpoint:^I^Ibits 15-18$
ERROR: code indent should never use tabs
#991: FILE: include/hw/xen/interface/io/usbif.h:129:
+ * - pipe type:^Ibits 30-31$
ERROR: code indent should never use tabs
#992: FILE: include/hw/xen/interface/io/usbif.h:130:
+ *^I^I^I^I(00 = isochronous, 01 = interrupt,$
ERROR: code indent should never use tabs
#993: FILE: include/hw/xen/interface/io/usbif.h:131:
+ *^I^I^I^I 10 = control, 11 = bulk)$
ERROR: code indent should never use tabs
#996: FILE: include/hw/xen/interface/io/usbif.h:134:
+#define USBIF_PIPE_PORT_MASK^I0x0000001f$
ERROR: code indent should never use tabs
#997: FILE: include/hw/xen/interface/io/usbif.h:135:
+#define USBIF_PIPE_UNLINK^I0x00000020$
ERROR: code indent should never use tabs
#998: FILE: include/hw/xen/interface/io/usbif.h:136:
+#define USBIF_PIPE_DIR^I^I0x00000080$
ERROR: code indent should never use tabs
#999: FILE: include/hw/xen/interface/io/usbif.h:137:
+#define USBIF_PIPE_DEV_MASK^I0x0000007f$
ERROR: code indent should never use tabs
#1000: FILE: include/hw/xen/interface/io/usbif.h:138:
+#define USBIF_PIPE_DEV_SHIFT^I8$
ERROR: code indent should never use tabs
#1001: FILE: include/hw/xen/interface/io/usbif.h:139:
+#define USBIF_PIPE_EP_MASK^I0x0000000f$
ERROR: code indent should never use tabs
#1002: FILE: include/hw/xen/interface/io/usbif.h:140:
+#define USBIF_PIPE_EP_SHIFT^I15$
ERROR: code indent should never use tabs
#1003: FILE: include/hw/xen/interface/io/usbif.h:141:
+#define USBIF_PIPE_TYPE_MASK^I0x00000003$
ERROR: code indent should never use tabs
#1004: FILE: include/hw/xen/interface/io/usbif.h:142:
+#define USBIF_PIPE_TYPE_SHIFT^I30$
ERROR: code indent should never use tabs
#1005: FILE: include/hw/xen/interface/io/usbif.h:143:
+#define USBIF_PIPE_TYPE_ISOC^I0$
ERROR: code indent should never use tabs
#1006: FILE: include/hw/xen/interface/io/usbif.h:144:
+#define USBIF_PIPE_TYPE_INT^I1$
ERROR: code indent should never use tabs
#1007: FILE: include/hw/xen/interface/io/usbif.h:145:
+#define USBIF_PIPE_TYPE_CTRL^I2$
ERROR: code indent should never use tabs
#1008: FILE: include/hw/xen/interface/io/usbif.h:146:
+#define USBIF_PIPE_TYPE_BULK^I3$
ERROR: code indent should never use tabs
#1010: FILE: include/hw/xen/interface/io/usbif.h:148:
+#define usbif_pipeportnum(pipe)^I^I^I((pipe) & USBIF_PIPE_PORT_MASK)$
ERROR: code indent should never use tabs
#1011: FILE: include/hw/xen/interface/io/usbif.h:149:
+#define usbif_setportnum_pipe(pipe, portnum)^I((pipe) | (portnum))$
ERROR: code indent should never use tabs
#1013: FILE: include/hw/xen/interface/io/usbif.h:151:
+#define usbif_pipeunlink(pipe)^I^I^I((pipe) & USBIF_PIPE_UNLINK)$
ERROR: code indent should never use tabs
#1014: FILE: include/hw/xen/interface/io/usbif.h:152:
+#define usbif_pipesubmit(pipe)^I^I^I(!usbif_pipeunlink(pipe))$
ERROR: code indent should never use tabs
#1015: FILE: include/hw/xen/interface/io/usbif.h:153:
+#define usbif_setunlink_pipe(pipe)^I^I((pipe) | USBIF_PIPE_UNLINK)$
ERROR: code indent should never use tabs
#1017: FILE: include/hw/xen/interface/io/usbif.h:155:
+#define usbif_pipein(pipe)^I^I^I((pipe) & USBIF_PIPE_DIR)$
ERROR: code indent should never use tabs
#1018: FILE: include/hw/xen/interface/io/usbif.h:156:
+#define usbif_pipeout(pipe)^I^I^I(!usbif_pipein(pipe))$
ERROR: code indent should never use tabs
#1020: FILE: include/hw/xen/interface/io/usbif.h:158:
+#define usbif_pipedevice(pipe)^I^I^I\$
ERROR: code indent should never use tabs
#1021: FILE: include/hw/xen/interface/io/usbif.h:159:
+^I^I(((pipe) >> USBIF_PIPE_DEV_SHIFT) & USBIF_PIPE_DEV_MASK)$
ERROR: code indent should never use tabs
#1023: FILE: include/hw/xen/interface/io/usbif.h:161:
+#define usbif_pipeendpoint(pipe)^I^I\$
ERROR: code indent should never use tabs
#1024: FILE: include/hw/xen/interface/io/usbif.h:162:
+^I^I(((pipe) >> USBIF_PIPE_EP_SHIFT) & USBIF_PIPE_EP_MASK)$
ERROR: code indent should never use tabs
#1026: FILE: include/hw/xen/interface/io/usbif.h:164:
+#define usbif_pipetype(pipe)^I^I^I\$
ERROR: code indent should never use tabs
#1027: FILE: include/hw/xen/interface/io/usbif.h:165:
+^I^I(((pipe) >> USBIF_PIPE_TYPE_SHIFT) & USBIF_PIPE_TYPE_MASK)$
ERROR: code indent should never use tabs
#1028: FILE: include/hw/xen/interface/io/usbif.h:166:
+#define usbif_pipeisoc(pipe)^I(usbif_pipetype(pipe) == USBIF_PIPE_TYPE_ISOC)$
ERROR: code indent should never use tabs
#1029: FILE: include/hw/xen/interface/io/usbif.h:167:
+#define usbif_pipeint(pipe)^I(usbif_pipetype(pipe) == USBIF_PIPE_TYPE_INT)$
ERROR: code indent should never use tabs
#1030: FILE: include/hw/xen/interface/io/usbif.h:168:
+#define usbif_pipectrl(pipe)^I(usbif_pipetype(pipe) == USBIF_PIPE_TYPE_CTRL)$
ERROR: code indent should never use tabs
#1031: FILE: include/hw/xen/interface/io/usbif.h:169:
+#define usbif_pipebulk(pipe)^I(usbif_pipetype(pipe) == USBIF_PIPE_TYPE_BULK)$
ERROR: code indent should never use tabs
#1034: FILE: include/hw/xen/interface/io/usbif.h:172:
+#define USBIF_MAX_PORTNR^I31$
ERROR: code indent should never use tabs
#1035: FILE: include/hw/xen/interface/io/usbif.h:173:
+#define USBIF_RING_SIZE^I4096$
ERROR: code indent should never use tabs
#1041: FILE: include/hw/xen/interface/io/usbif.h:179:
+^Igrant_ref_t gref;$
ERROR: code indent should never use tabs
#1042: FILE: include/hw/xen/interface/io/usbif.h:180:
+^Iuint16_t offset;$
ERROR: code indent should never use tabs
#1043: FILE: include/hw/xen/interface/io/usbif.h:181:
+^Iuint16_t length;$
ERROR: code indent should never use tabs
#1047: FILE: include/hw/xen/interface/io/usbif.h:185:
+^Iuint16_t id; /* request id */$
ERROR: code indent should never use tabs
#1048: FILE: include/hw/xen/interface/io/usbif.h:186:
+^Iuint16_t nr_buffer_segs; /* number of urb->transfer_buffer segments */$
ERROR: code indent should never use tabs
#1050: FILE: include/hw/xen/interface/io/usbif.h:188:
+^I/* basic urb parameter */$
ERROR: code indent should never use tabs
#1051: FILE: include/hw/xen/interface/io/usbif.h:189:
+^Iuint32_t pipe;$
ERROR: code indent should never use tabs
#1052: FILE: include/hw/xen/interface/io/usbif.h:190:
+^Iuint16_t transfer_flags;$
ERROR: code indent should never use tabs
#1053: FILE: include/hw/xen/interface/io/usbif.h:191:
+#define USBIF_SHORT_NOT_OK^I0x0001$
ERROR: code indent should never use tabs
#1054: FILE: include/hw/xen/interface/io/usbif.h:192:
+^Iuint16_t buffer_length;$
ERROR: code indent should never use tabs
#1055: FILE: include/hw/xen/interface/io/usbif.h:193:
+^Iunion {$
ERROR: code indent should never use tabs
#1056: FILE: include/hw/xen/interface/io/usbif.h:194:
+^I^Iuint8_t ctrl[8]; /* setup_packet (Ctrl) */$
ERROR: code indent should never use tabs
#1058: FILE: include/hw/xen/interface/io/usbif.h:196:
+^I^Istruct {$
ERROR: code indent should never use tabs
#1059: FILE: include/hw/xen/interface/io/usbif.h:197:
+^I^I^Iuint16_t interval; /* maximum (1024*8) in usb core */$
ERROR: code indent should never use tabs
#1060: FILE: include/hw/xen/interface/io/usbif.h:198:
+^I^I^Iuint16_t start_frame; /* start frame */$
ERROR: code indent should never use tabs
#1061: FILE: include/hw/xen/interface/io/usbif.h:199:
+^I^I^Iuint16_t number_of_packets; /* number of ISO packet */$
ERROR: line over 90 characters
#1062: FILE: include/hw/xen/interface/io/usbif.h:200:
+ uint16_t nr_frame_desc_segs; /* number of
iso_frame_desc segments */
ERROR: code indent should never use tabs
#1062: FILE: include/hw/xen/interface/io/usbif.h:200:
+^I^I^Iuint16_t nr_frame_desc_segs; /* number of iso_frame_desc segments */$
ERROR: code indent should never use tabs
#1063: FILE: include/hw/xen/interface/io/usbif.h:201:
+^I^I} isoc;$
ERROR: code indent should never use tabs
#1065: FILE: include/hw/xen/interface/io/usbif.h:203:
+^I^Istruct {$
ERROR: code indent should never use tabs
#1066: FILE: include/hw/xen/interface/io/usbif.h:204:
+^I^I^Iuint16_t interval; /* maximum (1024*8) in usb core */$
ERROR: code indent should never use tabs
#1067: FILE: include/hw/xen/interface/io/usbif.h:205:
+^I^I^Iuint16_t pad[3];$
ERROR: code indent should never use tabs
#1068: FILE: include/hw/xen/interface/io/usbif.h:206:
+^I^I} intr;$
ERROR: code indent should never use tabs
#1070: FILE: include/hw/xen/interface/io/usbif.h:208:
+^I^Istruct {$
ERROR: code indent should never use tabs
#1071: FILE: include/hw/xen/interface/io/usbif.h:209:
+^I^I^Iuint16_t unlink_id; /* unlink request id */$
ERROR: code indent should never use tabs
#1072: FILE: include/hw/xen/interface/io/usbif.h:210:
+^I^I^Iuint16_t pad[3];$
ERROR: code indent should never use tabs
#1073: FILE: include/hw/xen/interface/io/usbif.h:211:
+^I^I} unlink;$
ERROR: code indent should never use tabs
#1075: FILE: include/hw/xen/interface/io/usbif.h:213:
+^I} u;$
ERROR: code indent should never use tabs
#1077: FILE: include/hw/xen/interface/io/usbif.h:215:
+^I/* urb data segments */$
ERROR: code indent should never use tabs
#1078: FILE: include/hw/xen/interface/io/usbif.h:216:
+^Istruct usbif_request_segment seg[USBIF_MAX_SEGMENTS_PER_REQUEST];$
ERROR: code indent should never use tabs
#1083: FILE: include/hw/xen/interface/io/usbif.h:221:
+^Iuint16_t id; /* request id */$
ERROR: code indent should never use tabs
#1084: FILE: include/hw/xen/interface/io/usbif.h:222:
+^Iuint16_t start_frame; /* start frame (ISO) */$
ERROR: code indent should never use tabs
#1085: FILE: include/hw/xen/interface/io/usbif.h:223:
+^Iint32_t status; /* status (non-ISO) */$
ERROR: code indent should never use tabs
#1086: FILE: include/hw/xen/interface/io/usbif.h:224:
+^Iint32_t actual_length; /* actual transfer length */$
ERROR: code indent should never use tabs
#1087: FILE: include/hw/xen/interface/io/usbif.h:225:
+^Iint32_t error_count; /* number of ISO errors */$
WARNING: line over 80 characters
#1091: FILE: include/hw/xen/interface/io/usbif.h:229:
+DEFINE_RING_TYPES(usbif_urb, struct usbif_urb_request, struct
usbif_urb_response);
ERROR: code indent should never use tabs
#1098: FILE: include/hw/xen/interface/io/usbif.h:236:
+^Iuint16_t id;$
ERROR: code indent should never use tabs
#1103: FILE: include/hw/xen/interface/io/usbif.h:241:
+^Iuint16_t id; /* request id */$
ERROR: code indent should never use tabs
#1104: FILE: include/hw/xen/interface/io/usbif.h:242:
+^Iuint8_t portnum; /* port number */$
ERROR: code indent should never use tabs
#1105: FILE: include/hw/xen/interface/io/usbif.h:243:
+^Iuint8_t speed; /* usb_device_speed */$
ERROR: code indent should never use tabs
#1106: FILE: include/hw/xen/interface/io/usbif.h:244:
+#define USBIF_SPEED_NONE^I0$
ERROR: code indent should never use tabs
#1107: FILE: include/hw/xen/interface/io/usbif.h:245:
+#define USBIF_SPEED_LOW^I^I1$
ERROR: code indent should never use tabs
#1108: FILE: include/hw/xen/interface/io/usbif.h:246:
+#define USBIF_SPEED_FULL^I2$
ERROR: code indent should never use tabs
#1109: FILE: include/hw/xen/interface/io/usbif.h:247:
+#define USBIF_SPEED_HIGH^I3$
WARNING: line over 80 characters
#1113: FILE: include/hw/xen/interface/io/usbif.h:251:
+DEFINE_RING_TYPES(usbif_conn, struct usbif_conn_request, struct
usbif_conn_response);
total: 93 errors, 6 warnings, 1036 lines checked
Patch 1/4 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/4 Checking commit 252595d3e0db (xen: Import other xen/io/*.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#93:
new file mode 100644
WARNING: Block comments use a leading /* on a separate line
#98: FILE: include/hw/xen/interface/io/console.h:1:
+/******************************************************************************
ERROR: spaces required around that '-' (ctx:VxV)
#129: FILE: include/hw/xen/interface/io/console.h:32:
+#define MASK_XENCONS_IDX(idx, ring) ((idx) & (sizeof(ring)-1))
^
ERROR: open brace '{' following struct go on the same line
#194: FILE: include/hw/xen/interface/io/fbif.h:45:
+struct xenfb_update
+{
ERROR: open brace '{' following struct go on the same line
#209: FILE: include/hw/xen/interface/io/fbif.h:60:
+struct xenfb_resize
+{
ERROR: open brace '{' following union go on the same line
#221: FILE: include/hw/xen/interface/io/fbif.h:72:
+union xenfb_out_event
+{
ERROR: open brace '{' following struct go on the same line
#247: FILE: include/hw/xen/interface/io/fbif.h:98:
+struct xenfb_refresh_period
+{
WARNING: Block comments use a leading /* on a separate line
#249: FILE: include/hw/xen/interface/io/fbif.h:100:
+ uint32_t period; /* period of refresh, in ms,
WARNING: Block comments use a trailing */ on a separate line
#250: FILE: include/hw/xen/interface/io/fbif.h:101:
+ * XENFB_NO_REFRESH if no refresh is needed */
ERROR: open brace '{' following union go on the same line
#256: FILE: include/hw/xen/interface/io/fbif.h:107:
+union xenfb_in_event
+{
ERROR: open brace '{' following struct go on the same line
#281: FILE: include/hw/xen/interface/io/fbif.h:132:
+struct xenfb_page
+{
ERROR: open brace '{' following struct go on the same line
#582: FILE: include/hw/xen/interface/io/kbdif.h:271:
+struct xenkbd_motion
+{
ERROR: open brace '{' following struct go on the same line
#609: FILE: include/hw/xen/interface/io/kbdif.h:298:
+struct xenkbd_key
+{
ERROR: open brace '{' following struct go on the same line
#640: FILE: include/hw/xen/interface/io/kbdif.h:329:
+struct xenkbd_position
+{
ERROR: open brace '{' following union go on the same line
#814: FILE: include/hw/xen/interface/io/kbdif.h:503:
+union xenkbd_in_event
+{
ERROR: open brace '{' following union go on the same line
#844: FILE: include/hw/xen/interface/io/kbdif.h:533:
+union xenkbd_out_event
+{
ERROR: open brace '{' following struct go on the same line
#872: FILE: include/hw/xen/interface/io/kbdif.h:561:
+struct xenkbd_page
+{
WARNING: Block comments use a leading /* on a separate line
#884: FILE: include/hw/xen/interface/io/netif.h:1:
+/******************************************************************************
ERROR: spaces required around that '<<' (ctx:VxV)
#1256: FILE: include/hw/xen/interface/io/netif.h:373:
+#define XEN_NETIF_CTRLF_GREF_readonly (1U<<_XEN_NETIF_CTRLF_GREF_readonly)
^
ERROR: spaces required around that '<<' (ctx:VxV)
#1771: FILE: include/hw/xen/interface/io/netif.h:888:
+#define NETTXF_csum_blank (1U<<_NETTXF_csum_blank)
^
ERROR: spaces required around that '<<' (ctx:VxV)
#1775: FILE: include/hw/xen/interface/io/netif.h:892:
+#define NETTXF_data_validated (1U<<_NETTXF_data_validated)
^
ERROR: spaces required around that '<<' (ctx:VxV)
#1779: FILE: include/hw/xen/interface/io/netif.h:896:
+#define NETTXF_more_data (1U<<_NETTXF_more_data)
^
ERROR: spaces required around that '<<' (ctx:VxV)
#1783: FILE: include/hw/xen/interface/io/netif.h:900:
+#define NETTXF_extra_info (1U<<_NETTXF_extra_info)
^
ERROR: spaces required around that '<<' (ctx:VxV)
#1805: FILE: include/hw/xen/interface/io/netif.h:922:
+#define XEN_NETIF_EXTRA_FLAG_MORE (1U<<_XEN_NETIF_EXTRA_FLAG_MORE)
^
ERROR: spaces required around that '<<' (ctx:VxV)
#1854: FILE: include/hw/xen/interface/io/netif.h:971:
+#define NETRXF_data_validated (1U<<_NETRXF_data_validated)
^
ERROR: spaces required around that '<<' (ctx:VxV)
#1858: FILE: include/hw/xen/interface/io/netif.h:975:
+#define NETRXF_csum_blank (1U<<_NETRXF_csum_blank)
^
ERROR: spaces required around that '<<' (ctx:VxV)
#1862: FILE: include/hw/xen/interface/io/netif.h:979:
+#define NETRXF_more_data (1U<<_NETRXF_more_data)
^
ERROR: spaces required around that '<<' (ctx:VxV)
#1866: FILE: include/hw/xen/interface/io/netif.h:983:
+#define NETRXF_extra_info (1U<<_NETRXF_extra_info)
^
ERROR: spaces required around that '<<' (ctx:VxV)
#1870: FILE: include/hw/xen/interface/io/netif.h:987:
+#define NETRXF_gso_prefix (1U<<_NETRXF_gso_prefix)
^
WARNING: Block comments use a leading /* on a separate line
#1900: FILE: include/hw/xen/interface/io/protocols.h:1:
+/******************************************************************************
WARNING: architecture specific defines should be avoided
#1931: FILE: include/hw/xen/interface/io/protocols.h:32:
+#if defined(__i386__)
WARNING: Block comments use a leading /* on a separate line
#1948: FILE: include/hw/xen/interface/io/xenbus.h:1:
+/*****************************************************************************
total: 24 errors, 8 warnings, 1943 lines checked
Patch 2/4 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/4 Checking commit 1d20f2a619b4 (xen: Import Xen public headers used by
xen-hvm.c)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50:
new file mode 100644
WARNING: Block comments use a leading /* on a separate line
#148: FILE: include/hw/xen/interface/hvm/ioreq.h:60:
+ uint8_t data_is_ptr:1; /* if 1, data above is the guest paddr
WARNING: Block comments use a trailing */ on a separate line
#149: FILE: include/hw/xen/interface/hvm/ioreq.h:61:
+ * of the real data to use. */
WARNING: architecture specific defines should be avoided
#174: FILE: include/hw/xen/interface/hvm/ioreq.h:86:
+#ifdef __XEN__
WARNING: architecture specific defines should be avoided
#180: FILE: include/hw/xen/interface/hvm/ioreq.h:92:
+#ifdef __XEN__
total: 0 errors, 5 warnings, 182 lines checked
Patch 3/4 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/4 Checking commit 919708ec26d3 (xen: Avoid VLA)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden
- Re: [Qemu-devel] [PATCH 3/4] xen: Import Xen public headers used by xen-hvm.c, (continued)
- Re: [Qemu-devel] [PATCH 3/4] xen: Import Xen public headers used by xen-hvm.c, Paul Durrant, 2019/06/17
- Re: [Qemu-devel] [PATCH 3/4] xen: Import Xen public headers used by xen-hvm.c, Anthony PERARD, 2019/06/17
- Re: [Qemu-devel] [PATCH 3/4] xen: Import Xen public headers used by xen-hvm.c, Paul Durrant, 2019/06/17
- Re: [Qemu-devel] [Xen-devel] [PATCH 3/4] xen: Import Xen public headers used by xen-hvm.c, Anthony PERARD, 2019/06/17
- Re: [Qemu-devel] [Xen-devel] [PATCH 3/4] xen: Import Xen public headers used by xen-hvm.c, Paul Durrant, 2019/06/18
- Re: [Qemu-devel] [Xen-devel] [PATCH 3/4] xen: Import Xen public headers used by xen-hvm.c, Anthony PERARD, 2019/06/18
[Qemu-devel] [PATCH 1/4] xen: Fix build with public headers, Anthony PERARD, 2019/06/17
[Qemu-devel] [PATCH 2/4] xen: Import other xen/io/*.h, Anthony PERARD, 2019/06/17
Re: [Qemu-devel] [Xen-devel] [PATCH 0/4] Fix build of Xen support + cleanup,
no-reply <=