Re: [Qemu-devel] [PATCH v1 03/17] tests/vm: pin ubuntu.i386 image

[Philippe Mathieu-Daudé]

On 6/19/19 9:40 PM, Alex Bennée wrote:
> From: Cleber Rosa <address@hidden>
> 
> It's a good practice to always have the same components used in tests.
> According to:
> 
>    https://cloud-images.ubuntu.com/releases/16.04/
> 
> New images are released from time to time, and the "release/"
> directory points to the latest release.  Let's pin to the latest
> available version, and while at it, set a hash for verification.
> 
> Signed-off-by: Cleber Rosa <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>

> Message-Id: <address@hidden>
> Signed-off-by: Alex Bennée <address@hidden>
> ---
>  tests/vm/ubuntu.i386 | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/vm/ubuntu.i386 b/tests/vm/ubuntu.i386
> index 12867b193f..7017e6d388 100755
> --- a/tests/vm/ubuntu.i386
> +++ b/tests/vm/ubuntu.i386
> @@ -61,7 +61,9 @@ class UbuntuX86VM(basevm.BaseVM):
>          return os.path.join(cidir, "cloud-init.iso")
>  
>      def build_image(self, img):
> -        cimg = 
> self._download_with_cache("https://cloud-images.ubuntu.com/releases/16.04/release/ubuntu-16.04-server-cloudimg-i386-disk1.img";)
> +        cimg = self._download_with_cache(
> +            
> "https://cloud-images.ubuntu.com/releases/16.04/release-20190605/ubuntu-16.04-server-cloudimg-i386-disk1.img";,
> +            
> sha256sum="e30091144c73483822b7c27193e9d47346dd1064229da577c3fedcf943f7cfcc")
>          img_tmp = img + ".tmp"
>          subprocess.check_call(["cp", "-f", cimg, img_tmp])
>          subprocess.check_call(["qemu-img", "resize", img_tmp, "50G"])
>