[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 03/25] i386/kvm: convert hyperv enlightenments pr
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PULL 03/25] i386/kvm: convert hyperv enlightenments properties from bools to bits |
Date: |
Mon, 24 Jun 2019 13:43:50 +0100 |
User-agent: |
mu4e 1.3.2; emacs 26.1 |
Vitaly Kuznetsov <address@hidden> writes:
> Alex Bennée <address@hidden> writes:
>
>>
>> This looks like it's broken the build:
>>
>> configure' '--without-default-devices' '--disable-user'
>>
>> with:
>>
>> /home/alex/lsrc/qemu.git/target/i386/hyperv-stub.c: In function
>> ‘kvm_hv_handle_exit’:
>> /home/alex/lsrc/qemu.git/target/i386/hyperv-stub.c:18:19: error: ‘X86CPU’
>> {aka ‘struct X86CPU’} has no member named ‘hyperv_synic’; did you mean
>> ‘hyperv_vendor_id’?
>> if (!cpu->hyperv_synic) {
>> ^~~~~~~~~~~~
>>
>> Does the stub need updating for the new flag? I'm a little confused
>> about the relationship between HyperV and KVM. I thought they were
>> different hypervisors?
>
> Yes, they are. But to run Windows guests we can pretend being Hyper-V
> :-)
>
> I'll send a patch to fix the stub if nobody beats me to it. Thanks!
See:
Subject: [PATCH] target/i386: fix feature check in hyperv-stub.c
Date: Mon, 24 Jun 2019 13:38:35 +0100
Message-Id: <address@hidden>
And let me know if it is correct. I'll include it in testing/next as
it is a build fix.
--
Alex Bennée
- [Qemu-devel] [PULL v2 00/25] Misc (mostly x86) patches for 2019-06-21, Paolo Bonzini, 2019/06/21
- [Qemu-devel] [PULL 04/25] i386/kvm: add support for KVM_GET_SUPPORTED_HV_CPUID, Paolo Bonzini, 2019/06/21
- [Qemu-devel] [PULL 01/25] kvm-all: Add/update fprintf's for kvm_*_ioeventfd_del, Paolo Bonzini, 2019/06/21
- [Qemu-devel] [PULL 02/25] hax: Honor CPUState::halted, Paolo Bonzini, 2019/06/21
- [Qemu-devel] [PULL 06/25] i386/kvm: document existing Hyper-V enlightenments, Paolo Bonzini, 2019/06/21
- [Qemu-devel] [PULL 10/25] i386/kvm: hv-evmcs requires hv-vapic, Paolo Bonzini, 2019/06/21
- [Qemu-devel] [PULL 14/25] KVM: Introduce kvm_arch_destroy_vcpu(), Paolo Bonzini, 2019/06/21
- [Qemu-devel] [PULL 15/25] target/i386: kvm: Use symbolic constant for #DB/#BP exception constants, Paolo Bonzini, 2019/06/21
- [Qemu-devel] [PULL 05/25] i386/kvm: move Hyper-V CPUID filling to hyperv_handle_properties(), Paolo Bonzini, 2019/06/21
- [Qemu-devel] [PULL 16/25] target/i386: kvm: Re-inject #DB to guest with updated DR6, Paolo Bonzini, 2019/06/21
- [Qemu-devel] [PULL 22/25] target/i386: kvm: Add nested migration blocker only when kernel lacks required capabilities, Paolo Bonzini, 2019/06/21