[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/6] i386: Remove unused host_cpudef variable
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH 2/6] i386: Remove unused host_cpudef variable |
Date: |
Tue, 25 Jun 2019 10:04:06 +0100 |
User-agent: |
Mutt/1.12.0 (2019-05-25) |
* Eduardo Habkost (address@hidden) wrote:
> The variable is completely unused, probably a leftover from
> previous code clean up.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
> target/i386/cpu.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index 1bad957f6e..cf03dc786e 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -3133,14 +3133,8 @@ static void max_x86_cpu_initfn(Object *obj)
> char vendor[CPUID_VENDOR_SZ + 1] = { 0 };
> char model_id[CPUID_MODEL_ID_SZ + 1] = { 0 };
> int family, model, stepping;
> - X86CPUDefinition host_cpudef = { };
> - uint32_t eax = 0, ebx = 0, ecx = 0, edx = 0;
> -
> - host_cpuid(0x0, 0, &eax, &ebx, &ecx, &edx);
> - x86_cpu_vendor_words2str(host_cpudef.vendor, ebx, edx, ecx);
>
> host_vendor_fms(vendor, &family, &model, &stepping);
> -
> cpu_x86_fill_model_id(model_id);
>
> object_property_set_str(OBJECT(cpu), vendor, "vendor", &error_abort);
> --
> 2.18.0.rc1.1.g3f1ff2140
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PATCH 0/6] x86 CPU model versioning, Eduardo Habkost, 2019/06/25
- [Qemu-devel] [PATCH 1/6] i386: Add x-force-features option for testing, Eduardo Habkost, 2019/06/25
- [Qemu-devel] [PATCH 2/6] i386: Remove unused host_cpudef variable, Eduardo Habkost, 2019/06/25
- Re: [Qemu-devel] [PATCH 2/6] i386: Remove unused host_cpudef variable,
Dr. David Alan Gilbert <=
- [Qemu-devel] [PATCH 3/6] qmp: Add "alias-of" field to query-cpu-definitions, Eduardo Habkost, 2019/06/25
- [Qemu-devel] [PATCH 4/6] i386: Infrastructure for versioned CPU models, Eduardo Habkost, 2019/06/25
- Re: [Qemu-devel] [PATCH 4/6] i386: Infrastructure for versioned CPU models, Dr. David Alan Gilbert, 2019/06/25
- Re: [Qemu-devel] [PATCH 4/6] i386: Infrastructure for versioned CPU models, Eduardo Habkost, 2019/06/25
- Re: [Qemu-devel] [PATCH 4/6] i386: Infrastructure for versioned CPU models, Dr. David Alan Gilbert, 2019/06/25
- Re: [Qemu-devel] [PATCH 4/6] i386: Infrastructure for versioned CPU models, Eduardo Habkost, 2019/06/25
- Re: [Qemu-devel] [PATCH 4/6] i386: Infrastructure for versioned CPU models, Dr. David Alan Gilbert, 2019/06/25
- Re: [Qemu-devel] [PATCH 4/6] i386: Infrastructure for versioned CPU models, Eduardo Habkost, 2019/06/25