[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Fix build error when VNC is configured out
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH] Fix build error when VNC is configured out |
Date: |
Tue, 25 Jun 2019 13:00:59 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
Hi Christophe,
On 6/25/19 11:24 AM, Christophe de Dinechin wrote:
> In hmp_change(), the variable hmp_mon is only used
> by code under #ifdef CONFIG_VNC. This results in a build
> error when VNC is configured out with the default of
> treating warnings as errors:
>
> monitor/hmp-cmds.c: In function ‘hmp_change’:
> monitor/hmp-cmds.c:1946:17: error: unused variable ‘hmp_mon’
> [-Werror=unused-variable]
> 1946 | MonitorHMP *hmp_mon = container_of(mon, MonitorHMP, common);
> | ^~~~~~~
>
> Signed-off-by: Christophe de Dinechin <address@hidden>
> ---
> monitor/hmp-cmds.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
> index c283dde0e9..038614da8e 100644
> --- a/monitor/hmp-cmds.c
> +++ b/monitor/hmp-cmds.c
> @@ -1943,7 +1943,6 @@ static void hmp_change_read_arg(void *opaque, const
> char *password,
>
> void hmp_change(Monitor *mon, const QDict *qdict)
> {
> - MonitorHMP *hmp_mon = container_of(mon, MonitorHMP, common);
> const char *device = qdict_get_str(qdict, "device");
> const char *target = qdict_get_str(qdict, "target");
> const char *arg = qdict_get_try_str(qdict, "arg");
> @@ -1952,6 +1951,7 @@ void hmp_change(Monitor *mon, const QDict *qdict)
> Error *err = NULL;
>
> #ifdef CONFIG_VNC
> + MonitorHMP *hmp_mon = container_of(mon, MonitorHMP, common);
Can you move it after 'if (!arg) {', the sole place where it is used?
Regardless:
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> if (strcmp(device, "vnc") == 0) {
> if (read_only) {
> monitor_printf(mon,
>