Re: [Qemu-devel] [PATCH 1/2] dma/rc4030: Fix off-by-one error in specified memory region size

[Philippe Mathieu-Daudé]

On 6/25/19 4:27 PM, Aleksandar Markovic wrote:
> From: Aleksandar Markovic <address@hidden>
> 
> The size is one byte less than it should be:
> 
> address-space: rc4030-dma
>   0000000000000000-00000000fffffffe (prio 0, i/o): rc4030.dma
> 
> rc4030 is used in MIPS Jazz board context.

Ah thanks :) I was planing to send this once at home tonight.

> Signed-off-by: Aleksandar Markovic <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

  (qemu) info mtree
  ...
  address-space: rc4030-dma
    0000000000000000-00000000ffffffff (prio 0, i/o): rc4030.dma

  address-space: dp8393x
    0000000000000000-00000000ffffffff (prio 0, i/o): rc4030.dma

Tested-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>  hw/dma/rc4030.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/dma/rc4030.c b/hw/dma/rc4030.c
> index 6ccafec..88ff271 100644
> --- a/hw/dma/rc4030.c
> +++ b/hw/dma/rc4030.c
> @@ -23,6 +23,7 @@
>   */
>  
>  #include "qemu/osdep.h"
> +#include "qemu/units.h"
>  #include "hw/hw.h"
>  #include "hw/mips/mips.h"
>  #include "hw/sysbus.h"
> @@ -678,7 +679,7 @@ static void rc4030_realize(DeviceState *dev, Error **errp)
>  
>      memory_region_init_iommu(&s->dma_mr, sizeof(s->dma_mr),
>                               TYPE_RC4030_IOMMU_MEMORY_REGION,
> -                             o, "rc4030.dma", UINT32_MAX);
> +                             o, "rc4030.dma", 4 * GiB);
>      address_space_init(&s->dma_as, MEMORY_REGION(&s->dma_mr), "rc4030-dma");
>  }
>  
>