[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RISU RFC PATCH v1 5/7] risugen: allow all byte-aligned
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [RISU RFC PATCH v1 5/7] risugen: allow all byte-aligned instructions |
Date: |
Thu, 27 Jun 2019 12:30:15 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 6/19/19 7:04 AM, Jan Bobek wrote:
> Accept all instructions whose bit length is divisible by 8. Note that
> the maximum instruction length (as specified in the config file) is 32
> bits, hence this change permits instructions which are 8 bits or 24
> bits long (16-bit instructions have already been considered valid).
>
> Note that while valid x86 instructions may be up to 15 bytes long, the
> length constraint described above only applies to the main opcode
> field, which is usually only 1 or 2 bytes long. Therefore, the primary
> purpose of this change is to allow 1-byte x86 opcodes.
>
> Signed-off-by: Jan Bobek <address@hidden>
> ---
> risugen | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-devel] [RISU RFC PATCH v1 0/7] Support for generating x86 SSE/SSE2 test images, Jan Bobek, 2019/06/19
- [Qemu-devel] [RISU RFC PATCH v1 2/7] risugen_x86_asm: add module, Jan Bobek, 2019/06/19
- [Qemu-devel] [RISU RFC PATCH v1 1/7] risugen_common: add insnv, randint_constr, rand_fill, Jan Bobek, 2019/06/19
- [Qemu-devel] [RISU RFC PATCH v1 3/7] risugen_x86_emit: add module, Jan Bobek, 2019/06/19
- [Qemu-devel] [RISU RFC PATCH v1 5/7] risugen: allow all byte-aligned instructions, Jan Bobek, 2019/06/19
- Re: [Qemu-devel] [RISU RFC PATCH v1 5/7] risugen: allow all byte-aligned instructions,
Richard Henderson <=
- [Qemu-devel] [RISU RFC PATCH v1 4/7] risugen_x86: add module, Jan Bobek, 2019/06/19
[Qemu-devel] [RISU RFC PATCH v1 7/7] x86.risu: add SSE2 instructions, Jan Bobek, 2019/06/19
[Qemu-devel] [RISU RFC PATCH v1 6/7] x86.risu: add SSE instructions, Jan Bobek, 2019/06/19