[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] virtio-gpu: fix unmap in error path
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH] virtio-gpu: fix unmap in error path |
Date: |
Fri, 28 Jun 2019 16:08:06 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 06/28/19 09:23, Gerd Hoffmann wrote:
> We land here in case not everything we've asked for could be mapped.
> So unmap only the bytes which have actually been mapped.
>
> Also we didn't access anything, so acces_len can be 0.
s/acces_len/access_len/
With that:
Reviewed-by: Laszlo Ersek <address@hidden>
Thank you!
Laszlo
>
> Reported-by: Laszlo Ersek <address@hidden>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> hw/display/virtio-gpu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
> index 2b0f66b1d68d..475a018c027c 100644
> --- a/hw/display/virtio-gpu.c
> +++ b/hw/display/virtio-gpu.c
> @@ -1048,9 +1048,9 @@ static int virtio_gpu_load(QEMUFile *f, void *opaque,
> size_t size,
> if (res->iov[i].iov_base) {
> dma_memory_unmap(VIRTIO_DEVICE(g)->dma_as,
> res->iov[i].iov_base,
> - res->iov[i].iov_len,
> + len,
> DMA_DIRECTION_TO_DEVICE,
> - res->iov[i].iov_len);
> + 0);
> }
> /* ...and the mappings for previous loop iterations */
> res->iov_cnt = i;
>