Re: [Qemu-devel] [PATCH 1/4] hw/i386: Factorize CPU routine

[Michael S. Tsirkin]

On Fri, Jun 28, 2019 at 11:44:07PM +0200, Sergio Lopez wrote:
> 
> Eduardo Habkost <address@hidden> writes:
> 
> > On Fri, Jun 28, 2019 at 01:53:46PM +0200, Sergio Lopez wrote:
> > [...]
> >>  /* Enables contiguous-apic-ID mode, for compatibility */
> >> -static bool compat_apic_id_mode;
> >> +bool compat_apic_id_mode;
> >
> > We can get rid of this global variable, see the patch I have just
> > sent:
> >
> >   [PATCH] pc: Move compat_apic_id_mode variable to PCMachineClass
> 
> Nice. I'll adapt the v2 of the patchset to assume this has been
> committed.
> 
> Thanks!
> Sergio.


or include it for completeness.