Re: [Qemu-devel] [PATCH 0/7] target/mips: Mips improvements for 4.1

[Aleksandar Rikalo]

> From: Aleksandar Markovic <address@hidden>
> Sent: Monday, July 1, 2019 1:04 PM
> To: address@hidden; Aleksandar Rikalo
> Cc: Aleksandar Markovic
> Subject: [PATCH 0/7] target/mips: Mips improvements for 4.1
>
> From: Aleksandar Markovic <address@hidden>
>
> A collection of misc MIPS improvements that would be nice to be
> integrated into 4.1.
>
> Aleksandar Markovic (7):
>   tcg/tests: target/mips: Amend MSA fixed point multiply tests
>   tcg/tests: target/mips: Amend MSA integer multiply tests
>   target/mips: Correct comments in msa_helper.c
>   target/mips: Correct comments in translate.c
>   tcg/tests: target/mips: Correct MSA test compilation and execution
>     order
>   target/mips: Unroll loops for MSA float max/min instructions
>   target/mips: Correct helper for MSA FCLASS.<W|D> instructions
>
>  target/mips/msa_helper.c                           | 244 ++++++++++-----
>  target/mips/translate.c                            | 347 
> +++++++++++++--------
>  tests/tcg/mips/include/wrappers_msa.h              |  16 +
>  .../ase/msa/fixed-multiply/test_msa_madd_q_h.c     | 216 +++++++++++++
>  .../ase/msa/fixed-multiply/test_msa_madd_q_w.c     | 216 +++++++++++++
>  .../ase/msa/fixed-multiply/test_msa_maddr_q_h.c    | 216 +++++++++++++
>  .../ase/msa/fixed-multiply/test_msa_maddr_q_w.c    | 216 +++++++++++++
>  .../ase/msa/fixed-multiply/test_msa_msub_q_h.c     | 216 +++++++++++++
>  .../ase/msa/fixed-multiply/test_msa_msub_q_w.c     | 216 +++++++++++++
>  .../ase/msa/fixed-multiply/test_msa_msubr_q_h.c    | 216 +++++++++++++
>  .../ase/msa/fixed-multiply/test_msa_msubr_q_w.c    | 216 +++++++++++++
>  .../user/ase/msa/int-multiply/test_msa_maddv_b.c   | 224 ++++++-------
>  .../user/ase/msa/int-multiply/test_msa_maddv_d.c   | 214 ++++++-------
>  .../user/ase/msa/int-multiply/test_msa_maddv_h.c   | 224 ++++++-------
>  .../user/ase/msa/int-multiply/test_msa_maddv_w.c   | 224 ++++++-------
>  .../user/ase/msa/int-multiply/test_msa_msubv_b.c   | 224 ++++++-------
>  .../user/ase/msa/int-multiply/test_msa_msubv_d.c   | 224 ++++++-------
>  .../user/ase/msa/int-multiply/test_msa_msubv_h.c   | 224 ++++++-------
>  .../user/ase/msa/int-multiply/test_msa_msubv_w.c   | 224 ++++++-------
>  .../mips/user/ase/msa/test_msa_compile_32r6eb.sh   |  32 +-
>  .../mips/user/ase/msa/test_msa_compile_32r6el.sh   |  32 +-
>  .../mips/user/ase/msa/test_msa_compile_64r6eb.sh   |  32 +-
>  .../mips/user/ase/msa/test_msa_compile_64r6el.sh   |  32 +-
>  tests/tcg/mips/user/ase/msa/test_msa_run_32r6eb.sh |  16 +-
>  tests/tcg/mips/user/ase/msa/test_msa_run_32r6el.sh |  16 +-
>  tests/tcg/mips/user/ase/msa/test_msa_run_64r6eb.sh |  16 +-
>  tests/tcg/mips/user/ase/msa/test_msa_run_64r6el.sh |  16 +-
>  27 files changed, 3165 insertions(+), 1144 deletions(-)
>  create mode 100644 
> tests/tcg/mips/user/ase/msa/fixed-multiply/test_msa_madd_q_h.c
>  create mode 100644 
> tests/tcg/mips/user/ase/msa/fixed-multiply/test_msa_madd_q_w.c
>  create mode 100644 
> tests/tcg/mips/user/ase/msa/fixed-multiply/test_msa_maddr_q_h.c
>  create mode 100644 
> tests/tcg/mips/user/ase/msa/fixed-multiply/test_msa_maddr_q_w.c
>  create mode 100644 
> tests/tcg/mips/user/ase/msa/fixed-multiply/test_msa_msub_q_h.c
>  create mode 100644 
> tests/tcg/mips/user/ase/msa/fixed-multiply/test_msa_msub_q_w.c
>  create mode 100644 
> tests/tcg/mips/user/ase/msa/fixed-multiply/test_msa_msubr_q_h.c
>  create mode 100644 
> tests/tcg/mips/user/ase/msa/fixed-multiply/test_msa_msubr_q_w.c
>
> --
> 2.7.4

In patch on translate.c it would be nice to fix all comment-related warnings.

Anyway:

Reviewed-by: Aleksandar Rikalo <address@hidden>