Re: [Qemu-devel] [RFC PATCH v2 0/3] python: refactor qemu/__init__.py

[Eduardo Habkost]

On Thu, Jun 27, 2019 at 05:32:17PM -0400, John Snow wrote:
> I didn't actually mean to retain the RFC tag, but oh well.

I'm queueing patch 1-2 for QEMU 4.1.

Patch 3 will require more careful review.  If you can demonstrate
it fixes a problem in some use cases, we can call it a bug fix
and include it after soft freeze.  ;)

> 
> On 6/27/19 5:28 PM, John Snow wrote:
> > There's a lot of code hiding in what is ostensibly a package
> > configuration file. Let's break that out into something more visible.
> > 
> > V2:
> >  - Retain python 2.7+ compatibility :(
> >  - Refactor shutdown a little more aggressively
> > 
> > John Snow (3):
> >   python/qemu: split QEMUMachine out from underneath __init__.py
> >   machine.py: minor delinting
> >   QEMUMachine: Don't suppress stack traces on close
> > 
> >  python/qemu/__init__.py                   | 502 +-------------------
> >  python/qemu/machine.py                    | 536 ++++++++++++++++++++++
> >  python/qemu/qtest.py                      |   2 +-
> >  scripts/device-crash-test                 |   2 +-
> >  scripts/render_block_graph.py             |   2 +-
> >  tests/acceptance/avocado_qemu/__init__.py |   2 +-
> >  tests/acceptance/virtio_version.py        |   2 +-
> >  tests/migration/guestperf/engine.py       |  22 +-
> >  tests/qemu-iotests/235                    |   2 +-
> >  tests/vm/basevm.py                        |   3 +-
> >  10 files changed, 556 insertions(+), 519 deletions(-)
> >  create mode 100644 python/qemu/machine.py
> > 
> 

-- 
Eduardo