Re: [Qemu-devel] [PATCH v2 3/9] i386: Get model-id from CPU object on "-cpu help"

[Daniel P . Berrangé]

On Thu, Jun 27, 2019 at 09:28:38PM -0300, Eduardo Habkost wrote:
> When introducing versioned CPU models, the string at
> X86CPUDefinition::model_id might not be the model-id we'll really
> use.  Instantiate a CPU object and check the model-id property on
> "-cpu help"

It would help understanding to illustrate this with an example
of the different string that results before/after this change.

> 
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> (New patch, added to series in v2)
> ---
>  target/i386/cpu.c | 16 +++++++++++++---
>  1 file changed, 13 insertions(+), 3 deletions(-)

Reviewed-by: Daniel P. Berrangé <address@hidden>



Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|