Re: [Qemu-devel] [PATCH v2 9/9] i386: Add Cascadelake-Server-v2 CPU model

[Daniel P . Berrangé]

On Thu, Jun 27, 2019 at 09:28:44PM -0300, Eduardo Habkost wrote:
> Add new version of Cascadelake-Server CPU model, setting
> stepping=5 and enabling the IA32_ARCH_CAPABILITIES MSR
> with some flags.
> 
> The new feature will introduce a new host software requirement,
> breaking our CPU model runnability promises.  This means we can't
> enable the new CPU model version by default in QEMU 4.1, because
> management software isn't ready yet to resolve CPU model aliases.
> This is why "pc-*-4.1" will keep returning Cascadelake-Server-v1
> if "-cpu Cascadelake-Server" is specified.

Hmm, yes, we don't actually need to answer the question I
raised in the earlier patch for another 2 releases yet,
as we'll be sticking with v1 for all machines for a while.

> 
> Includes a test case to ensure the right combinations of
> machine-type + CPU model + command-line feature flags will work
> as expected.
> 
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> Changes v1 -> v2:
> * Enable rdctl-no, ibrs-all, skip-l1dfl-vmentry
>   (Suggested by Tao Xu)
> 
> Cc: "Hu, Robert" <address@hidden>
> Cc: Tao Xu <address@hidden>
> Cc: address@hidden,
> Cc: "Lai, Paul C" <address@hidden>
> ---
>  target/i386/cpu.c                          | 14 +++++
>  tests/acceptance/x86_cpu_model_versions.py | 73 ++++++++++++++++++++++
>  2 files changed, 87 insertions(+)

Reviewed-by: Daniel P. Berrangé <address@hidden>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|