[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/7] virtio-pmem: add virtio device
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/7] virtio-pmem: add virtio device |
Date: |
Tue, 2 Jul 2019 13:46:53 +0200 |
On Wed, 19 Jun 2019 15:19:01 +0530
Pankaj Gupta <address@hidden> wrote:
> This is the implementation of virtio-pmem device. Support will require
> machine changes for the architectures that will support it, so it will
> not yet be compiled. It can be unlocked with VIRTIO_PMEM_SUPPORTED per
> machine and disabled globally via VIRTIO_PMEM.
>
> We cannot use the "addr" property as that is already used e.g. for
> virtio-pci/pci devices. And we will have e.g. virtio-pmem-pci as a proxy.
> So we have to choose a different one (unfortunately). "memaddr" it is.
> That name should ideally be used by all other virtio-* based memory
> devices in the future.
> -device virtio-pmem-pci,id=p0,bus=bux0,addr=0x01,memaddr=0x1000000...
>
> Acked-by: Markus Armbruster <address@hidden>
> [ QAPI bits ]
> Signed-off-by: Pankaj Gupta <address@hidden>
> [ MemoryDevice/MemoryRegion changes, cleanups, addr property "memaddr",
> split up patches, unplug handler ]
> Signed-off-by: David Hildenbrand <address@hidden>
> ---
> hw/virtio/Kconfig | 10 +++
> hw/virtio/Makefile.objs | 1 +
> hw/virtio/virtio-pmem.c | 189
> ++++++++++++++++++++++++++++++++++++++++
> include/hw/virtio/virtio-pmem.h | 49 +++++++++++
> qapi/misc.json | 28 +++++-
> 5 files changed, 276 insertions(+), 1 deletion(-)
> create mode 100644 hw/virtio/virtio-pmem.c
> create mode 100644 include/hw/virtio/virtio-pmem.h
>
> diff --git a/qapi/misc.json b/qapi/misc.json
> index dc4cf9da20..6f1bff10e4 100644
> --- a/qapi/misc.json
> +++ b/qapi/misc.json
> @@ -2738,16 +2738,42 @@
> }
> }
>
> +##
> +# @VirtioPMEMDeviceInfo:
> +#
> +# VirtioPMEM state information
> +#
> +# @id: device's ID
> +#
> +# @memaddr: physical address in memory, where device is mapped
> +#
> +# @size: size of memory that the device provides
> +#
> +# @memdev: memory backend linked with device
> +#
> +# Since: 4.1
Not sure if this can still make it...
> +##
> +{ 'struct': 'VirtioPMEMDeviceInfo',
> + 'data': { '*id': 'str',
> + 'memaddr': 'size',
> + 'size': 'size',
> + 'memdev': 'str'
> + }
> +}
> +
> ##
> # @MemoryDeviceInfo:
> #
> # Union containing information about a memory device
> #
> +# nvdimm is included since 2.12. virtio-pmem is included since 4.1.
> +#
> # Since: 2.1
> ##
> { 'union': 'MemoryDeviceInfo',
> 'data': { 'dimm': 'PCDIMMDeviceInfo',
> - 'nvdimm': 'PCDIMMDeviceInfo'
> + 'nvdimm': 'PCDIMMDeviceInfo',
> + 'virtio-pmem': 'VirtioPMEMDeviceInfo'
> }
> }
>
Reviewed-by: Cornelia Huck <address@hidden>
- [Qemu-devel] [PULL 06/22] virtio-pci: Allow to specify additional interfaces for the base type, (continued)
- [Qemu-devel] [PULL 06/22] virtio-pci: Allow to specify additional interfaces for the base type, Michael S. Tsirkin, 2019/07/02
- [Qemu-devel] [PULL 07/22] virtio-pmem: sync linux headers, Michael S. Tsirkin, 2019/07/02
- Re: [Qemu-devel] [PATCH v2 3/7] virtio-pmem: sync linux headers, Cornelia Huck, 2019/07/02
- Re: [Qemu-devel] [PATCH v2 3/7] virtio-pmem: sync linux headers, Pankaj Gupta, 2019/07/02
- Re: [Qemu-devel] [PATCH v2 3/7] virtio-pmem: sync linux headers, Michael S. Tsirkin, 2019/07/02
- Re: [Qemu-devel] [PATCH v2 3/7] virtio-pmem: sync linux headers, Pankaj Gupta, 2019/07/02
- Re: [Qemu-devel] [PATCH v2 3/7] virtio-pmem: sync linux headers, Michael S. Tsirkin, 2019/07/02
- Re: [Qemu-devel] [PATCH v2 3/7] virtio-pmem: sync linux headers, Pankaj Gupta, 2019/07/02
- Re: [Qemu-devel] [PATCH v2 3/7] virtio-pmem: sync linux headers, Michael S. Tsirkin, 2019/07/02
[Qemu-devel] [PULL 05/22] virtio-pmem: add virtio device, Michael S. Tsirkin, 2019/07/02
[Qemu-devel] [PULL 08/22] virtio-pci: Proxy for virtio-pmem, Michael S. Tsirkin, 2019/07/02
Re: [Qemu-devel] [PULL 08/22] virtio-pci: Proxy for virtio-pmem, Peter Maydell, 2019/07/11
[Qemu-devel] [PULL 10/22] numa: Handle virtio-pmem in NUMA stats, Michael S. Tsirkin, 2019/07/02